Hi Barry, Am 22.09.2017 um 02:08 schrieb Barry Warsaw: > Hi guys, apologies for not responding earlier. I have taken a break from > Debian development, so I am not reading my @debian.org email much these days: > > https://lists.debian.org/debian-python/2017/08/msg00107.html > > That said...
no worries. It's great that you clearly communicated your decision to the teams you're involved and I very well can understand it. Hope that you feel joy and pleasure soon again while doing Debian stuff :) >> On Sep 20, 2017, at 12:53, Jonas Meurer <jo...@freesources.org> wrote: > >> @barry: I could do the uploads but as you're PEB's sponsor so far you >> might want to do that yourself. Maybe you also want to review the latest >> changes to the packages? That would be awesome. > > Jonas, Mattia, thank you very much for working with PEB, and thanks to PEB > for being so diligent about getting Mailman 3 into Debian! I wholeheartedly > support your sponsorship of these packages while I am on hiatus. > > I did a quick review of the core package, and noticed just a few things: Thanks a lot for your review. It's much appreciated and of great help! I'll only comment on the things PEB didn't comment on yet. > In d/tests/mailman3-core-tests, what do you think about using `python3 -m > nose2` instead of `nose2-3`? > > Another interesting integration test might be to start up MM3’s REST API and > GET the /3.1/system/versions resource, then either print the JSON or compare > its value to something expected. It’s at least a minimal sniff test that > some runners could be started up. As discussed in upstream issue #400[1], there seems to be no easy solution to run the nose2 testsuite - neither during build in debian/rules, nor with the package being installed via autopkgtests. Thus I finally decided to go with two other simple tests, as you suggested: * create a simple test list * fetch http://localhost:8001/3.1/system/versions via curl [1] https://gitlab.com/mailman/mailman/issues/400 Cheers, jonas
