Le jeudi 21 septembre 2017 à 20:08:30-0400, Barry Warsaw a écrit : > Hi guys, apologies for not responding earlier. I have taken a break from > Debian development, so I am not reading my @debian.org email much these days: > > https://lists.debian.org/debian-python/2017/08/msg00107.html > > That said... > > > On Sep 20, 2017, at 12:53, Jonas Meurer <jo...@freesources.org> wrote: > > > @barry: I could do the uploads but as you're PEB's sponsor so far you > > might want to do that yourself. Maybe you also want to review the latest > > changes to the packages? That would be awesome. > > Jonas, Mattia, thank you very much for working with PEB, and thanks to PEB > for being so diligent about getting Mailman 3 into Debian! I wholeheartedly > support your sponsorship of these packages while I am on hiatus. > > I did a quick review of the core package, and noticed just a few things: > > d/copyright should really go back to 1998. Even though Mailman 3 was forked > from Mailman 2 only in the last few years, there’s enough code inherited from > the early days to warrant the earlier copyright start year.
Done! > In d/tests/mailman3-core-tests, what do you think about using `python3 -m > nose2` instead of `nose2-3`? As I wasn't able to have working tests for this package, they're disabled in d/rules. Maybe I just should remove this file. > Another interesting integration test might be to start up MM3’s REST API and > GET the /3.1/system/versions resource, then either print the JSON or compare > its value to something expected. It’s at least a minimal sniff test that > some runners could be started up. I think this requires more background on mailman3 functionnalities that I currently have. Maybe I'll set this suggestion in debian/TODO for later! > If and when you get a real manpage, please write it in reST, convertible via > rst2man and contribute it back upstream! Sure! > autopkgtest fails for me with: > > After this operation, 159 MB of additional disk space will be used. > Err:1 http://httpredir.debian.org/debian sid/main amd64 python3-falcon amd64 > 1.0.0-2+b1 > 404 Not Found > E: Failed to fetch > http://httpredir.debian.org/debian/pool/main/p/python-falcon/python3-falcon_1.0.0-2+b1_amd64.deb > 404 Not Found > E: Unable to fetch some archives, maybe run apt-get update or try with > --fix-missing? > autopkgtest [20:07:28]: ERROR: testbed failure: apt repeatedly failed to > download packages I guess I'm not able to do such test myself. Thanks for your time! Cheers, -- PEB
signature.asc
Description: PGP signature
