On Thu, Dec 6, 2012 at 11:23 AM, Aron Xu <a...@debian.org> wrote: > I've done a quick review of spl-linux package in PPA, and overall the > package is in acceptable state on technical side, and here are my > comments:
(Thanks.) > 1. Version number of upstream release needs to be mangled to something > like 0.6.0~rc12, because 0.6.0-rc12 is larger than 0.6.0, and 0.6.0.xx > isn't that easy to identify for users. > > 2. Recommend to clear d/changelog for uploading to Debian, it's a new start, > :-) I asked upstream about this concern earlier. The current plan is to release the first non-RC as version 0.6.1 and use git-buildpackage versioning afterwards. (ie: There will be no official 0.6.0 release, only release candidates.) I intend to clear the changelog when I branch for wheezy and raring, and then use separate branches thereafter. > 3. Use compat 9 and Build-Depends on debhelper >= 9, this makes your > binaries in usr/sbin being hardened at build-time. > > 4. Architecture should be linux-any, as they are only intended for Linux. > > 5. Revise descriptions in d/control based on Carlos's current draft in ITP. > > 6. Update Standards-Version to 3.9.4 > > 7. spl-dkms.postinst spl-dkms.prerm should be removed because they are > not actually used. > > 8. Add a dedicate paragraph in d/copyright for GPL-2+. Okay, done. See: https://github.com/dajhorn/pkg-spl/commit/e07989f936096ef82b7807f904caed26c02a864a -- Darik Horn <dajh...@vanadac.com> -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAPbcu1Pt_JQR1t6xEVfqa-m=ro1041e8lfmof-hwbn_-cyb...@mail.gmail.com
