I've done a quick review of spl-linux package in PPA, and overall the package is in acceptable state on technical side, and here are my comments:
1. Version number of upstream release needs to be mangled to something like 0.6.0~rc12, because 0.6.0-rc12 is larger than 0.6.0, and 0.6.0.xx isn't that easy to identify for users. 2. Recommend to clear d/changelog for uploading to Debian, it's a new start, :-) 3. Use compat 9 and Build-Depends on debhelper >= 9, this makes your binaries in usr/sbin being hardened at build-time. 4. Architecture should be linux-any, as they are only intended for Linux. 5. Revise descriptions in d/control based on Carlos's current draft in ITP. 6. Update Standards-Version to 3.9.4 7. spl-dkms.postinst spl-dkms.prerm should be removed because they are not actually used. 8. Add a dedicate paragraph in d/copyright for GPL-2+. -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMr=8w4rxjjapoyydkuc61p5heq8ohg6vce_lglz7kz_hg3...@mail.gmail.com
