Hi! I have built this package on my side (from SVN trunk) and tested it. This is a rather long review with multiple bug reports, so I hope you can find the time or patience to sift through my rants. ;)
Postinst failure
================
It seems there is a problem in the postinst file
Paramétrage de ledgersmb (1.3.15-1) ...
Module rewrite already enabled
Restarting web server: apache2 ... waiting .
dpkg : erreur de traitement de ledgersmb (--configure) :
le sous-processus script post-installation installé a retourné une
erreur de sortie d'état 10
configured to not write apport reports
Des erreurs ont été rencontrées
pendant l'exécution :
ledgersmb
E: Sub-process /usr/bin/dpkg returned an error code (1)
The problem is this:
debconf (developer): <-- GET ledgersmb/lsmb_debconf
debconf (developer): --> 10 ledgersmb/lsmb_debconf doesn't exist
and here's a fix:
Index: debian/ledgersmb.postinst
===================================================================
--- debian/ledgersmb.postinst (révision 512)
+++ debian/ledgersmb.postinst (copie de travail)
@@ -60,7 +60,7 @@
drop_statoverride
fi
# If enabled, do the debconf supported configuration
- db_get ledgersmb/lsmb_debconf
+ db_get ledgersmb/debconf_install
if [ "$RET" = true ]; then
dbc_go ledgersmb $@
fi
Default postgres configuration problem
======================================
The other problem i am having is it seems the psql user isn't being
created properly. I can't connect to the postgres database using the
password i chose or the default password. This requires an extra
configuration on the postgresql side, where i need the following:
-local all all ident
+#local all all ident
+local all all md5
Also, I get the following error when logging in through setup.pl:
Cannot find Contrib script tablefunc.sql in /usr/share/pgsql/contrib/.
While there are some instructions in the README.Debian file about this,
it is rather counter-intuitive. This desserves a bigger warning in the
README...
Credentials issue
=================
Then I got the following error when trying to create a DB:
DBD::Pg::db do failed: ERREUR: droit refusé pour créer une base de
données at LedgerSMB/Database.pm line 413.
This is in french, and means "refused right to create a
database...". Maybe the ledgersmb user wasn't created properly? The
README mentions that the package may have done that for you, so I was
assuming this would work. At least mentionning how to grant those rights
would go a long way.
(I noticed, after writing all this, that this is in the TODO... oh well :)
For the record, that is:
# su postgres
$ psql
postgres=# ALTER USER ledgersmb SUPERUSER LOGIN NOINHERIT;
Login problem
=============
.. but even after this it seems that while I can create the DB and a
user for myself, i can't login to the site with that user. the apache
error log tells me:
DBI connect('dbname=lsmb13','anarcat',...) failed: FATAL: la base de
donn?es << lsmb13 >> n'existe pas at LedgerSMB.pm line 981
... which means the "lsmb13 database doesn't exist". This is fixed by
changing the default_db config option to "ledgersmb".
I have struggled to find documentation on how to create or recreate the
user now, and I have failed: the setup.pl doesn't give me grants
management, and commandline scripts only create new databases.
DB version problem
==================
When I finally am able to login to the site, I see this in both frames:
Database is not the expected version. Was , expected 1.3.15. Please
re-run setup.pl against this database to correct.
I get this in the error log:
DBD::Pg::st execute failed: ERREUR: la relation « defaults » n'existe
pas
LINE 2: SELECT value FROM defaults
^ at LedgerSMB.pm line 1010.
DBD::Pg::st fetchrow_array failed: no statement executing at
LedgerSMB.pm line 1011.
Interestingly enough, the defaults table *does* exist in the database I
created for that company. It doesn't, however, exist in the "ledgersmb"
database...
This is the final blocker that keeps me from using this package right
now.
Overall
=======
Otherwise: good work on the package, I may be able to upload this to
unstable now that I am a debian member. :) Of course we'd need to fix at
least the postinst issue, and I think improving the documentation could
go a long way. Finally, if the DB version problem is upstream, I would
understand and just upload the package already...
Cheers,
A.
--
L'art n'est pas un bureau d'anthropométrie.
- Léo Ferré, "Préface"
pgpiBKDP1zLfD.pgp
Description: PGP signature
