>> 12m12.4s ERROR: WARN: Processes are running inside chroot:
>> 12m20.4s ERROR: WARN: Broken symlinks:
>> 12m55.1s ERROR: FAIL: Package purging left files on system:
>> 
>> of which I'd consider the processes left running in the chroot to be
>> seriously broken.
>
>It is a WARN and not FAIL. You can't suddenly change meaning of these
>just before the release to make it RC.

And the actual problem for the piuparts test failing currently 
is a ton of cruft lying around after the package was purged:

https://piuparts.debian.org/sid/fail/gitlab_8.13.6+dfsg2-1.log

12m55.1s ERROR: FAIL: Package purging left files on system:
  /etc/gitlab-shell/     not owned
  /etc/gitlab-shell/config.yml   not owned
  /etc/rc0.d/K01gitlab -> ../init.d/gitlab       not owned
  /etc/rc1.d/K01gitlab -> ../init.d/gitlab       not owned
  /etc/rc2.d/S01gitlab -> ../init.d/gitlab       not owned
  /etc/rc3.d/S01gitlab -> ../init.d/gitlab       not owned
  /etc/rc4.d/S01gitlab -> ../init.d/gitlab       not owned
  /etc/rc5.d/S01gitlab -> ../init.d/gitlab       not owned
  /etc/rc6.d/K01gitlab -> ../init.d/gitlab       not owned
  /etc/systemd/system/gitlab.service -> /dev/null        not owned
  /etc/systemd/system/gitlab.target -> /dev/null         not owned
  /etc/systemd/system/gitlab.target.wants/       not owned
  /etc/systemd/system/gitlab.target.wants/gitlab.service -> 
/lib/systemd/system/gitlab.service   not owned
  /etc/systemd/system/multi-user.target.wants/gitlab.target -> 
/lib/systemd/system/gitlab.target         not owned
  /usr/share/gitlab-shell/.gitlab_shell_secret -> 
/var/lib/gitlab/.gitlab_shell_secret   not owned
  /var/cache/gitlab/     not owned
  /var/lib/gitlab/       owned by: gitlab
  /var/lib/gitlab/.bundle/       not owned
  /var/lib/gitlab/.bundle/config         not owned
  /var/lib/gitlab/.gitconfig     not owned
  /var/lib/gitlab/.gitlab_shell_secret   not owned
  /var/lib/gitlab/.gitlab_workhorse_secret       not owned
  /var/lib/gitlab/.ssh/  not owned
  /var/lib/gitlab/.ssh/authorized_keys   not owned
  /var/lib/gitlab/Gemfile.lock   not owned
  /var/lib/gitlab/db/    owned by: gitlab
  /var/lib/gitlab/db/schema.rb   not owned
  /var/lib/gitlab/gitlab-debian.conf     not owned
  /var/lib/gitlab/gitlab-shell-config.yml        not owned
  /var/lib/gitlab/gitlab.yml     not owned
  /var/lib/gitlab/nginx.conf     not owned
  /var/lib/gitlab/public/        owned by: gitlab
  /var/lib/gitlab/public/uploads/        not owned
  /var/lib/gitlab/repositories/  not owned
  /var/lib/gitlab/secrets.yml    not owned
  /var/lib/systemd/deb-systemd-helper-enabled/gitlab.service.dsh-also    not 
owned
  /var/lib/systemd/deb-systemd-helper-enabled/gitlab.target.dsh-also     not 
owned
  /var/lib/systemd/deb-systemd-helper-enabled/gitlab.target.wants/       not 
owned
  
/var/lib/systemd/deb-systemd-helper-enabled/gitlab.target.wants/gitlab.service  
       not owned
  
/var/lib/systemd/deb-systemd-helper-enabled/multi-user.target.wants/gitlab.target
      not owned
  /var/lib/systemd/deb-systemd-helper-masked/    not owned
  /var/lib/systemd/deb-systemd-helper-masked/gitlab.service      not owned
  /var/lib/systemd/deb-systemd-helper-masked/gitlab.target       not owned
  /var/log/gitlab-shell/         not owned
  /var/log/gitlab-shell/gitlab-shell.log         not owned
  /var/log/gitlab/       not owned
  /var/log/gitlab/application.log        not owned
  /var/log/gitlab/builds/        not owned
  /var/log/gitlab/production.log         not owned

Looks like initscripts integration is not done properly.
Empty directories could be shipped in the package - and dpkg will take care of 
them.
Log files should be removed.

Anyway, only leaving stuff around should qualify for an
ignore-piuparts hint (or however it was called).
I didn't look at the other bug about redis-server.
Which one btw? I didn't see anything RC open.

Ideally, we will have more finegrained classification of
piuparts results at some point ...


Andreas

Reply via email to