Hi Eric, Eric Evans <eev...@debian.org> (2013-08-12): > In python-coherence, coherence.upnp.core.utils.HeaderAwareHTTPClientFactory > (coherence/upnp/core/utils.py) sub-classes twisted.web.client.HTTPDownloader > (from package python-twisted-web), and in the process (uselessly )overrides > the __init__ method and makes use of a "private" attribute. As a result, it > broke when that attribute was dropped in a major release of Twisted. > > I think this bug is grave. Anything that uses utils.getPage is affected, > which includes the internal control point; The default config and all of > the examples fail predictably. > > It was reported in 664027[1] in March of 2012, but went unfixed and was > released as part of wheezy, (the bug priority was "important"). > > The attached patch came from the corresponding upstream bug report[2], and > has been well tested by myself and others (see replies to [1] and [2]). > > I just adopted coherence and have uploaded the fix to unstable, is there any > chance a fix could make its way to stable-proposed-updates as well?
it looks reasonable to me; please post a debdiff with that patch applied on top of 0.6.6.2-6, versioned as 0.6.6.2-6+deb7u1 (I don't mind updated Maintainer/Uploaders in the process), targeting 'wheezy' for a last review. Mraw, KiBi.
signature.asc
Description: Digital signature
