On Mon, Sep 17, 2012 at 20:53:25 +0300, Eugene V. Lyubimkin wrote:
> Hello Josh and Release Team, maintainer of htop here.
>
> On 2012-08-31 21:49, Adam D. Barratt wrote:
> > On Wed, 2012-08-08 at 01:55 +0200, Cyril Brulebois wrote:
> > > Josh Triplett <j...@joshtriplett.org> (30/07/2012):
> > > > +--- trunk/Settings.c 2012/02/17 13:45:58 285
> > > > ++++ trunk/Settings.c 2012/03/05 11:12:58 286
> > > > +@@ -239,7 +239,9 @@
> > > > + mkdir(htopDir, 0700);
> > > > + free(htopDir);
> > > > + free(configDir);
> > > > +- if (access(legacyDotfile, R_OK) != 0) {
> > > > ++ struct stat st;
> > > > ++ lstat(legacyDotfile, &st);
> > >
> > > No error checking here…
> > >
> > > RETURN VALUE
> > > On success, zero is returned. On error, -1 is returned, and
> > > errno is
> > > set appropriately.
> > >
> > > What does S_ISLNK() do when an error was reached?
> > >
> > > Surely that could be improved?
> >
> > Ping?
>
> So I/we got the problem. I uploaded 1.0.1-2 after Josh said it should be
> fine by Release Team. Some timer after I uploaded -3 and -4 to fix the
> bug #685670.
>
> Then I now come to ask for the unblock for -4 and see that -2 is not
> really get through.
>
> The upstream patch in question isn't perfect but the whole htop source
> isn't either. Can I still please ask for unblock for -2 as a part of
> asking to unblock -4?
>
Please fix the bugs that were pointed in review...Cheers, Julien
signature.asc
Description: Digital signature
