Hi Adam, hi Cajus + Benoit, On Montag, 26. Dezember 2011, Adam D. Barratt wrote: > > ldap2zone-0.1/debian/patches/05_correct_bashisms_ldap2bind.dpatch > What does the proposed change have to do with fixing bashisms?
in the 0.2-2 upload (which is in sid and will reach wheezy in 2 days) the patch is just called debian-changes-0.2-2. > > if [ $? -ne 0 ]; then > > > > - echo -e "Reloading the zone '$domain' failed:\n$result" 1>&2 > > > > -+ printf "Reloading the zone '$domain' failed: $result\n" 1>&2 > > ++ logger -t ldap2bind "Reloading the zone '$domain' failed: > > $result\n" 1>&2 > > > > + else > > > > -+ printf "Reloading the zone '$domain' was successful\n" 1>&2 > > ++ logger -t ldap2bind "Reloading the zone '$domain' was > > successful\n" 1>&2 > > > > fi > > I have to admit that my first thought here was much the same as > Julien's - if the problem is that mail is being sent on the successful > completion of a job which is expected to succeed, why is a change also > being made to the failure path? So, for a squeeze update only the failed branch of the if statement should be changed. (I agree with that too, fwiw.) (Right, Adam? No need to reply if "yes" :) Cajus + Benoit, can you handle this? Else I'm happy to prepare an NMU for s-p-u with this change, so that the fix reaches 6.0.4. cheers, Holger -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201201011815.07620.hol...@layer-acht.org