Package: release.debian.org
Severity: normal
Tags: bookworm
Control: affects -1 + src:gss
User: release.debian....@packages.debian.org
Usertags: pu

Hi!  I am trying to follow/learn the process to get something updated in
a stable point release.

[ Reason ]

Resolve FTBFS bug due to expiring Kerberos ticket in
tests/krb5context.tkt causing self-tests to error out:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076885

tests/krb5context.tkt:

  name:authtime  type:GENERALIZED_TIME  value:20040711155558Z
  name:endtime  type:GENERALIZED_TIME  value:20240711155558Z

[ Tests ]

A similar fix has been uploaded to unstable in 1.0.4-4 and migrated to
testing:

https://buildd.debian.org/status/package.php?p=gss
https://salsa.debian.org/debian/gss/-/pipelines/788603

[ Risks ]

On salsa the bookworm i386 build fails but I don't understand why: the
build log suggests datefudge is working because of the makefile out of
date warnings, but still the test self fail as if the current date is
still used.  Could this be a datefudge problem on i386 on bookworm
inside Salsa CI runners?  Is there a i386 porter/bookworm box available
for testing?  The same fix built fine on buildds though.

https://salsa.debian.org/debian/gss/-/pipelines/789791

[ Checklist ]

  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in stable
  [x] the issue is verified as fixed in unstable

[ Changes ]

  * Use datefudge to fix time bomb.  Closes: #1076885.

/Simon
diff -Nru gss-1.0.4/debian/changelog gss-1.0.4/debian/changelog
--- gss-1.0.4/debian/changelog	2022-08-06 17:20:38.000000000 +0200
+++ gss-1.0.4/debian/changelog	2024-12-29 22:44:14.000000000 +0100
@@ -1,3 +1,9 @@
+gss (1.0.4-1+deb12u1) bookworm; urgency=medium
+
+  * Use datefudge to fix time bomb.  Closes: #1076885.
+
+ -- Simon Josefsson <si...@josefsson.org>  Sun, 29 Dec 2024 22:44:14 +0100
+
 gss (1.0.4-1) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru gss-1.0.4/debian/control gss-1.0.4/debian/control
--- gss-1.0.4/debian/control	2022-08-06 16:17:21.000000000 +0200
+++ gss-1.0.4/debian/control	2024-12-29 22:44:14.000000000 +0100
@@ -4,6 +4,7 @@
 Maintainer: Debian GSS Team <help-...@gnu.org>
 Uploaders: Simon Josefsson <si...@josefsson.org>, Russ Allbery <r...@debian.org>
 Build-Depends: debhelper-compat (= 13),
+	       datefudge,
                help2man,
                libshishi-dev,
                texinfo,
diff -Nru gss-1.0.4/debian/rules gss-1.0.4/debian/rules
--- gss-1.0.4/debian/rules	2022-08-06 16:18:43.000000000 +0200
+++ gss-1.0.4/debian/rules	2024-12-29 22:44:14.000000000 +0100
@@ -38,5 +38,8 @@
 	make -C build/doc gss.html gss.pdf
 endif
 
+override_dh_auto_test:
+	datefudge "2020-01-01" dh_auto_test $(DH_BUILD_OPTS)
+
 override_dh_compress:
 	dh_compress -Xgss.pdf
diff -Nru gss-1.0.4/debian/tests/control gss-1.0.4/debian/tests/control
--- gss-1.0.4/debian/tests/control	2022-08-06 16:17:56.000000000 +0200
+++ gss-1.0.4/debian/tests/control	2024-12-29 22:44:14.000000000 +0100
@@ -1,2 +1,2 @@
 Tests: gss
-Depends: build-essential, libgss-dev, man, pkg-config
+Depends: build-essential, datefudge, libgss-dev, man, pkg-config
diff -Nru gss-1.0.4/debian/tests/gss gss-1.0.4/debian/tests/gss
--- gss-1.0.4/debian/tests/gss	2022-08-06 16:14:51.000000000 +0200
+++ gss-1.0.4/debian/tests/gss	2024-12-29 22:42:58.000000000 +0100
@@ -9,6 +9,7 @@
 for f in $(ls tests/*.c | grep -v utils.c); do
     gcc -I$WORKDIR -o $WORKDIR/foo $f `pkg-config --cflags --libs gss shishi`
     echo PASS: gcc $f
+    datefudge "2020-01-01" \
     env SHISHI_KEYS=tests/krb5context.key \
 	SHISHI_TICKETS=tests/krb5context.tkt \
 	SHISHI_CONFIG=tests/shishi.conf \

Attachment: signature.asc
Description: PGP signature

Reply via email to