Hi Eric,
I took a look again at your updated audiotools package (versioned
3.0-1) on mentors.d.n. Just a few comments:
Do you really need strict versions on *all* your build-deps and
dependencies? I'd strongly recommend only using versioned
deps/build-deps when necessary, otherwise e.g. you make it harder for
others to backport your package.
debian/patches is empty and can be removed
debian/copyright:
- src/bitstream{.c,.h,-table.c} are dual-licensed (LGPL-3+ or GPL-2+),
but not mentioned in d/copyright
- src/output/sfifo.{c,h} are licensed under LGPL-2.1, not 2.1+ as you
claim in d/copyright
...and some other d/copyright-related issues caught by lintian (as
well as a number of other info-priority tags you may want to look at):
I: audiotools source: wildcard-matches-nothing-in-dep5-copyright
src/decoders/dvd_css.c (paragraph at line 25)
I: audiotools source: wildcard-matches-nothing-in-dep5-copyright
src/decoders/dvd_css.h (paragraph at line 25)
I: audiotools source: wildcard-matches-nothing-in-dep5-copyright
src/decoders/csstables.h (paragraph at line 32)
I: audiotools source: wildcard-matches-nothing-in-dep5-copyright
src/decoders/ioctl.c (paragraph at line 36)
I: audiotools source: wildcard-matches-nothing-in-dep5-copyright
src/decoders/ioctl.h (paragraph at line 47)
I: audiotools source: unused-file-paragraph-in-dep5-copyright
paragraph at line 25
I: audiotools source: unused-file-paragraph-in-dep5-copyright
paragraph at line 32
I: audiotools source: unused-file-paragraph-in-dep5-copyright
paragraph at line 36
I: audiotools source: unused-file-paragraph-in-dep5-copyright
paragraph at line 47
Regards,
Vincent
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
https://lists.debian.org/caczd_tdft8u+r61y5uxtueqemawk91ndjobh812gtzhomtf...@mail.gmail.com
