On Sun, 3 Aug 2014 22:27:11 -0700 Vincent Cheng <vch...@debian.org> wrote:
>
> Sorry for not following up on my earlier debian-mentors review until now!
>
> Agreed with Eriberto, your package is in pretty good shape, however
> there are a few more issues:
>
> Blockers:
> - debian/copyright needs the full text of CC-BY-SA-3.0-US and
> CC-BY-SA-2.5 ("visit http://creativecommons.org/licenses/by-sa/2.5/";
> won't pass ftpmaster review)
Done. Wrapped legalcode text from each respective Creative Commons
website output to 78 col, indented, and added ' .' on blank lines.
>
> Non-blockers, but please fix anyhow:
> - your very first debian/changelog entry should always just be akin to
> "Initial release. (Closes: #550216)" (i.e. your ITP bug report). You
> don't need to mention any of your other changes.
OK. Done.
> - rename debian/audiotools.docs to debian/docs
> (debian/package.{docs,install,manpages,...} is redundant if your
> source package only builds a single binary package)
Renamed.
>
> If you haven't already, please forward those patches upstream.
> Patching in license headers the way you're doing right now should only
> be a short-term thing, and you want it upstream-ed asap.
>
Upstream applied changes to new stable release 2.22 ; see:
http://http://mentors.debian.net/package/audiotools
dget -x
http://mentors.debian.net/debian/pool/main/a/audiotools/audiotools_2.22-1.dsc
Eric
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
https://lists.debian.org/canv2ptpadvgoanjq0pm2hccvtqfn86a+g_t6km_jrmb7fz5...@mail.gmail.com
