Hello Andrey, first thank you for your review.
Am Donnerstag, den 20.11.2014, 00:01 +0500 schrieb Andrey Rahmatullin: > On Wed, Nov 19, 2014 at 09:08:39AM +0100, Jörg Frings-Fürst wrote: > > dget -x > > http://mentors.debian.net/debian/pool/main/p/python-instagram/python-instagram_1.2.0-1.dsc > I think you should put the commit ID from which you've generated the orig > tarball into the package upstream version or at least into the changelog. Instead upload the master.tar.gz tarball I have changed the the debian/rules get-orig-source to use the upstream git repository. > You must use python3:Depends instead of python:Depends for python2 > subpackages (there are two warnings from dpkg-gencontrol about this). Done. > All packages explicitly mentioned in the Depends field are added in > corresponding python{,3}:Depends so you should drop them. Done. > Priority should be optional. Done. > Using a more restrictive license for debian/ than is used for the upstream > source is discouraged. I always use GLP-3+ for debian/* and set the license of debian/patches/* to the license of the source file(s). > Also, consider joining the DPMT[1] and maintaining the package there. > > [1] https://wiki.debian.org/Teams/PythonModulesTeam > > CU Jörg -- pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E pgp Key: BE581B6E CAcert Key S/N: 0E:D4:56 Jörg Frings-Fürst D-54526 Niederkail Threema: SYR8SJXB IRC: j_...@freenode.net j_...@oftc.net
signature.asc
Description: This is a digitally signed message part
