Hi Jörg,
Thanks a lot for your work. Uploaded.
Cheers,
Eriberto
2014-09-19 4:53 GMT-03:00 Jörg Frings-Fürst <deb...@jff-webhosting.net>:
> Hola Eriberto,
>
>
> first many thanks for your review.
>
>
> Am Donnerstag, den 18.09.2014, 15:52 -0300 schrieb Eriberto:
>> Hi Jörg,
>>
>> Thanks for all adjustments. Please:
>>
>> - d/changelog: change urgency from medium to low.
> done.
>>
>> - d/control:
>> - Add a VCS to control your package.
>
>> - I suggest to add the name 'MailWebsiteChanges' in long description.
>
>> - Put a dot in end of the first phrase in long description.
>> - Remove ${shlibs:Depends} because interpreted languages doesn't use it.
>> - Why you have dh-systemd as build dependency?
> Both removed.
>>
>> - d/copyright:
>> - The upstream code is GPL-2+, not GPL-2.
>> - Where you saw that upstream site is GPL-2?
> My error. I'm looking for "at your opinion" instead of "at your option"
> in the LICENSE. And found them not.
> Change to GPL-2+.
>
>> Do you have permission
>> to add this content in your package? I suggest to list the site in
>> d/README.Debian, not include the site.
> I think you mean the debian/docs. I have got the docu from the upstream
> author with a entry in d/copyright. Removed and I put a short reference
> into d/README.Debian.
>>
>> - d/mwc.1: add a reference about you, Debian and free usage of the
>> manpage. This is important because manpages are published in several
>> sites (without the source code) and someone might want to contact you.
>> You can see an example here[1]. (go to the end of page)
>>
>> [1] http://sources.debian.net/src/mac-robber/1.02-3/debian/man/mac-robber.1
>>
> Done.
>
>> - d/mwc.cron.hourly: I think that isn't a good idea this file, because
>> you are forcing the user machine to connect the Internet without a
>> express permission. Ok, a NTP client do it. However, I think that the
>> situation is different. Other point is that, initially, will not exist
>> an user configuration and the mwc will try connect even so.
>>
> I have moved them from etc/cron.hourly into examples with a tip in
> d/README.Debian.
>
>> d/rules: remove all comments.
>>
> done.
>
>> d/watch: githubredir is deprecated. Please, see here[2] how to make a
>> d/watch.
>>
>> [2] http://eriberto.pro.br/blog/?p=1459
>>
> Also done. And uploaded again to mentors[1]
>
>> Thanks for your work.
>>
>> Cheers,
>>
>> Eriberto
>>
> [...]
>
> CU
> Jörg
>
>
> [1] http://mentors.debian.net/debian/pool/main/m/mwc/mwc_1.7.2-1.dsc
>
> --
> pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E
> pgp Key: BE581B6E
> CAcert Key S/N: 0E:D4:56
>
> Jörg Frings-Fürst
> D-54526 Niederkail
>
> Threema: SYR8SJXB
>
> IRC: j_...@freenode.net
> j_...@oftc.net
>
>
>
>
>
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
https://lists.debian.org/cap+dxjfpn8ctb4jymna1c447rcdc+mvfzib-rdukvd9yjk_...@mail.gmail.com
