Hi Jörg,
Thanks for all adjustments. Please:
- d/changelog: change urgency from medium to low.
- d/control:
- Add a VCS to control your package.
- I suggest to add the name 'MailWebsiteChanges' in long description.
- Put a dot in end of the first phrase in long description.
- Remove ${shlibs:Depends} because interpreted languages doesn't use it.
- Why you have dh-systemd as build dependency?
- d/copyright:
- The upstream code is GPL-2+, not GPL-2.
- Where you saw that upstream site is GPL-2? Do you have permission
to add this content in your package? I suggest to list the site in
d/README.Debian, not include the site.
- d/mwc.1: add a reference about you, Debian and free usage of the
manpage. This is important because manpages are published in several
sites (without the source code) and someone might want to contact you.
You can see an example here[1]. (go to the end of page)
[1] http://sources.debian.net/src/mac-robber/1.02-3/debian/man/mac-robber.1
- d/mwc.cron.hourly: I think that isn't a good idea this file, because
you are forcing the user machine to connect the Internet without a
express permission. Ok, a NTP client do it. However, I think that the
situation is different. Other point is that, initially, will not exist
an user configuration and the mwc will try connect even so.
d/rules: remove all comments.
d/watch: githubredir is deprecated. Please, see here[2] how to make a d/watch.
[2] http://eriberto.pro.br/blog/?p=1459
Thanks for your work.
Cheers,
Eriberto
2014-09-18 12:00 GMT-03:00 Jörg Frings-Fürst <deb...@jff-webhosting.net>:
> Hola Eriberto,
>
>
> thanks that you will review mwc.
>
> Sorry for the delay. I have test and change something.
>
> Am Mittwoch, den 17.09.2014, 18:05 -0300 schrieb Eriberto Mota:
>> tags 748878 moreinfo
>> thanks
>>
>>
>> Hi again Jörg,
>>
>> I am ready to review your package. Can you update the package to make
>> easier my review?
>
> My changes:
>
> - remove preinst with install cssselect
> - add Depend python-cssselect
> - debian/rules:
> use of dh_python3
> rewrite for more debhelper usage
> - debian/copyright
> change upstream license from GPL-2.0+ to GPL-2
> - remove useless startscripts
>
>
>>
>> Cheers,
>>
>> Eriberto
> [...]
>
> CU
> Jörg
>
> [1] http://mentors.debian.net/debian/pool/main/m/mwc/mwc_1.7.2-1.dsc
>
> --
> pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E
> pgp Key: BE581B6E
> CAcert Key S/N: 0E:D4:56
>
> Jörg Frings-Fürst
> D-54526 Niederkail
>
> Threema: SYR8SJXB
>
> IRC: j_...@freenode.net
> j_...@oftc.net
>
>
>
>
>
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
https://lists.debian.org/cap+dxjfe9jh9ngerqmqvomcsqqjfbubuvna7m4gdqreugym...@mail.gmail.com
