Il 24/04/2013 19:51, Jakub Wilk ha scritto:
> * Giulio Paci <giuliop...@gmail.com>, 2013-04-14, 13:21:
>>> Using "except" without specifying exception type is bad idea:
>>> http://docs.python.org/2/howto/doanddont.html#except
>> Added 1008_avoid_except_usage_without_type.patch. The situation is not very
>> much different anyway, as the patch just replaces "except" with "except
>> Exception".
>
> Yeah; at least it doesn't swallow KeyboardInterrupt. :)
>
> There are still some instances of "except:" left: in g2p.py and in misc.py.
Should be fixed now.
> In mGramCounts.py and LanguageModel.py I see this code:
> self.fname = tempfile.mkstemp('counts')[1]
> This leaks a filedescriptor... (This doesn't affect Debian AFAICT, so I'm
> mentioning it here only if case upstream awakens.)
I just fixed, just in case...
> In February you wrote:
>> let's wait a few more days before dropping the indentation_fixes.patch.
> So, can we drop it now? :) It makes .debian.tar almost as big as .orig.tar...
Unfortunately yes, we can drop it (and so I did).
I tried several times to contact upstream by email without any luck...
I was able to get in contact with the original author, but he is not working at
RTWH anymore, then I tried to contact the head of the department, but he is not
responding
to my emails.
Bests,
Giulio.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/517f20d1.5010...@gmail.com
