Hi Bob, I've reviewed the latest version of your packaging, and I'd be happy to upload it. Thank you very much for all the work that you've put into the package. Unwinding all the of the patches into quilt format in particular is quite impressive (and I suspect will make it easier for other distributions or an eventual new GNU maintainer).
Bart and Sandro, I don't want to jump in if you would like to be the sponsor and don't want to step on other people. If you're okay with me sponsoring this package going forward, though, I'm happy to do so. Bob Proulx <b...@proulx.com> writes: > Bart Martens wrote: >> The file debian/copyright "should name the original authors", and >> David Keppel is such an author. > Thank you for taking the time to look at the copyright file in detail. > I admit the new DEP5 format confuses me. I need to find some actual > examples in the field of more than the very simple examples listed in > the documentation. I am working from this document: > http://dep.debian.net/deps/dep5/ You should instead use: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ not that this would resolve your question, since there isn't anywhere in the format to record authors who do not hold copyright. As mentioned in my other message, I don't think this is really the purpose of the debian/copyright file. What you have now seems fine to me. > I was working from the Debian quilt howto here which said it was > required. Of course that is explicitly for Perl but for this aspect it > shouldn't matter. > http://pkg-perl.alioth.debian.org/howto/quilt.html#readme_source > I find it annoying so am happy to remove it. But I find your statement > that the quilt format doesn't use quilt surprising! And in fact it was > required specifically that I convert the package to use the quilt > format. README.source is required if unpacking the source package doesn't result in a version of the source with all patches applied, ready to build. The expectation is that dpkg-source -x will result in the source that will be built in Debian, and if that is not true, README.source should document how to get to that point. Previously, this meant that packages using quilt would need README.source, since you would have to take an explicit step after unpacking to apply the patches. However, with the 3.0 (quilt) source format, dpkg-source understands the format natively and applies all the patches automatically, thus fulfilling that requirement and obviating the need for additional documentation. I tested the package and it seems to work fine. I noticed three nits, which I don't think need to be fixed for this upload, but which might be worth considering in future versions of the package: * To suppress the Lintian warnings about changelog syntax errors, you can use the method documented in the Lintian long tag description: N: While parsing the Debian changelog, a syntax error was found. If you N: have old changelog entries that don't follow the current syntax but that N: you want to keep as-is for the historical record, add the line: N: N: Old Changelog: N: N: with no leading whitespace before the legacy entries. This line and N: everything after it will be ignored. * There seems to be something odd about the time info file. If I run info time, and then press space, rather than proceeding to the next child node the way that info normally does, info just reports "no more nodes in this file." The same is true at a few points in the child node tree. Is the *.texinfo file possibly missing metadata or proper section links? * The formatting of the man page isn't great. There are a few places that seem to have spurious line breaks (the --append documentation, for example), and it's traditional to have a blank line between each option documented in OPTIONS. The second problem at least can be fixed by just deleting the .PD 0 command (or at least moving it down to the formatting section, if it's still desireable for the resource specifiers. -- Russ Allbery (r...@debian.org) <http://www.eyrie.org/~eagle/> -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87sjdmmtuy....@windlord.stanford.edu
