(I don't intend to sponsor this NMU.)
* Rob Adams <rad...@artlogic.com>, 2012-05-31, 11:53:
dget -x
http://mentors.debian.net/debian/pool/main/p/python-cups/python-cups_1.9.61-0.1.dsc
[...]
Changes since the last upload:
* Non-maintainer upload.
* New upstream release. (Resolves: #656640)
Did you mean s/Resolved/Closes/?
* debian/control:
- bump standard-version to 3.9.3
Were any packaging changes needed to do this? Anyway, this not
appropriate for any NMU.
* debian/compat:
- bump to 9
Were any packaging changes needed to do this? Again, not appropriate for
an NMU.
* debian/rules:
- switch from python-support to dh_python2
We don't do things like this in an NMU.
What is this:
| binary-*:
| dh_python2
(in debian/rules) supposed to do?
You added "X-Python-Version: >= 2.6", presumably because the new
upstream version doesn't support with 2.5 anymore. Do you know why?
You forgot to bump B-D on python-all-dev to >= 2.6.6-3~ (for dh_python2
support).
* debian/source.lintian-override:
- package-needs-versioned-debhelper-build-depends 9.
No, lintian is correct. Fix the bug instead.
Other changes you made that are not documented in the changelog:
- added a trailing comma Uploaders (?!);
- changed package description;
- changed debian/copyright;
- removed a patch;
- added DEB_BUILD_HARDENING=1 and DEB_BUILD_HARDENING_STACKPROTECTOR=1
in debian/rules (?!);
- prepended -fstack-protector to CFLAGS (shouldn't you use
dpkg-buildflags to acquire CFLAGS instead?).
Why "[RC]" in the bug title? As far as I can see the only bug this
package fixes has severity normal.
--
Jakub Wilk
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120605150346.ga6...@jwilk.net
