Hi Jakub, Can you take a look again?
On Fr 20 Jan 2012 01:06:47 CET Jakub Wilk wrote:
I'd remove the commented-out commands from debian/rules.
-> DONE
I'd also remove also explicit "install" and "binary-indep" targets, since the wildcard "%" do exactly the same.
-> DONE
You provide "build-arch" and "build-indep" targets, but they do something different than the "build" target. That's bad. (dpkg-buildpackage currently doesn't use build-* targets, but it might start doing so in the future.)
-> DONE, fixed by the fix above
You should not explicitly delete debian/*.log, debian/<packagename>, etc. dh_clean takes care of this.
-> DONE
Deleting debian/patches in the clean target is certainly a bad idea!
-> DONE, fixed by above fix
You define PYVERS variable in debian/rules, but you don't use it anywhere.
-> DONE
Upstream provides a test suite, please run it at build time (preferably using all supported Python versions).
-> Upstream's test suite is not at all functional
Does this package support Python 2.5? debian/pyversions says it does, XS-Python-Version says it doesn't. Please use only one of them, BTW.
-> DONE
XB-Python-Version is deprecated, please remove it.
-> DONE
">= 0.13.0-0~0" is a pretty weird version constraint. Maybe ">= 0.13.0" or even ">= 0.13" could be used instead?
-> DONE
You should close the ITP in the changelog.
-> DONE
I (and most other sponsor here) normally require one changelog entry per upload to the archive.
-> DONE
Lintian emits some experimental and informative tags that you might want to fix:X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/frames.html > > usr/share/doc/python-x2go/html/index.html X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.control._stdout-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.info._stdout-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.terminal._stdout-module.html X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.printing._gconf-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.profiles._gconf-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.settings._gconf-module.html X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.printing._file-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.profiles._file-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.settings._file-module.html X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.printing._winreg-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.profiles._winreg-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.settings._winreg-module.htmlI: python-x2go: possible-documentation-but-no-doc-base-registration
-> I have not touched these as they are auto-generated.
It looks like documentation takes much more space than the rest of the package (7.6M vs 780K unpacked). Since end users don't need the documentation, maybe it'd be worthwhile to split it into a separate package?
-> DONE
I'd exclude x2go.tests module from the binary package.
-> TODO, not sure how to do that...
setup.py have install_requires = ['setuptools', ...], but the package doesn't depend on python-setuptools. So either setup.py or the Depends is wrong (probably the former).
-> DONE (by patch 002_...
x2go/monkey_patch_paramiko.py has a different license than the rest of the code, but this is not documented in debian/copyright.
-> DONE (was an upstream mistake, in the new upstream the license is the same)
The strange status of x2go/gevent_subprocess.py is probably worth documenting, too.
-> DONE
./x2go/backends/terminal/_stdout.py:325: undefined name > 'X2goTerminalSessionException'$ pyflakes . | grep ': undefined name' ./x2go/mimebox.py:100: undefined name 'mimebox_actions' ./x2go/checkhosts.py:225: undefined name 'random' ./x2go/checkhosts.py:225: undefined name 'string' ./x2go/checkhosts.py:225: undefined name 'string' ./x2go/log.py:123: undefined name 'types' ./x2go/log.py:125: undefined name 'types' ./x2go/mimeboxactions.py:92: undefined name 'self' ./x2go/mimeboxactions.py:100: undefined name 'self' ./x2go/mimeboxactions.py:152: undefined name 'WindowsError' ./x2go/utils.py:63: undefined name 'stdout' ./x2go/client.py:997: undefined name 'X2goSessionExceptionRegistryException' ./x2go/printactions.py:98: undefined name 'self' ./x2go/printactions.py:106: undefined name 'self' ./x2go/printactions.py:191: undefined name 'WindowsError' ./x2go/backends/profiles/_gconf.py:51: undefined name 'X2goNotImplementedYetException'./x2go/backends/profiles/_winreg.py:51: undefined name 'X2goNotImplementedYetException' ./x2go/backends/profiles/_httpsbroker.py:50: undefined name 'X2goNotImplementedYetException' ./x2go/backends/profiles/_file.py:83: undefined name 'check_profile_id_or_name' ./x2go/backends/settings/_gconf.py:64: undefined name 'X2goNotImplementedYetException' ./x2go/backends/settings/_winreg.py:64: undefined name 'X2goNotImplementedYetException'./x2go/backends/control/_stdout.py:171: undefined name 'SSHException'./x2go/backends/printing/_winreg.py:75: undefined name 'X2goNotImplementedYetException'
./x2go/backends/terminal/_stdout.py:942: undefined name 'X2goTerminalSessionException' ./x2go/backends/terminal/_stdout.py:944: undefined name 'X2goTerminalSessionException'
I believe that the above are mostly (or all) true positives. -> DONE (by patch 001_...) THANKS!!! Mike -- DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419 GnuPG Key ID 0xB588399B mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
pgp28fvaia14B.pgp
Description: Digitale PGP-Unterschrift
