On Fri, 9 Apr 2010 23:21:58 +0100, Tim Retout wrote: > I've read through the packaging briefly. Minor comments: please > consider using a space after the commas in Build-Depends. Fix.
> I'm not sure that you need the entries in debian/dirs, which I > presume are created by the upstream Makefile. It's probably neater to In fact without the dirs file or a httpry.dirs, the package is not build (fakeroot complains that some directory doesn't exist). > prefix all the debhelper files with the package name, e.g. > "debian/httpry.docs". Indeed, more explicit. > I would modify debian/rules to use the short form of dh, and put > things like the man page filename into debian/httpry.manpages. You > might need to override dh_installchangelogs for the upstream > changelog. (Although these changes are "just" a matter of style, > really.) > I haven't checked the copyright thoroughly, but I notice that the > source contains copyright notices for 2005-2009, not just 2009 as > listed in debian/copyright. Right. I fixed the copyright file. > It might be better to license your packaging changes under GPL-2+, > same as the program itself - that way, it's easier for someone else to > submit your patches upstream later, for example. Fix. > Can you tell me what makes httpry better or different to using tcpdump > and wireshark? As in, if it gets uploaded, is it going to have enough > users reporting bugs and so on? Well, httpry snoops only HTTP traffic and perform a first level of analysis by summarizing conversation (timestamp, peer, URL, HTTP method, success code, etc.). It's really convenient in cache-proxy environment to quickly see what/how the client asks, what/how the proxy/webserver replies without accessing proxy/server logs. No GUI, and really explicit logs. Wireshark is overkill for such task and tcpdump floods me by displaying all HTTP packets. httpry is simple, fast, and do good job for such tasks. Really thank you for your review and your advices. I uploaded a new version on mentors website with two other fixes based upon your other comment (and M. E. Anderssonon) regarding the debian version number (as you recommend I keep the -1), and thus fix the changelog. The updated package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/h/httpry - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/h/httpry/httpry_0.1.5-1.dsc Best regards, Yann. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100411170859.e06144cf.yleje...@netyl.org
