Hi Dne Tue, 18 Aug 2009 01:44:08 +0000 Leinier Cruz Salfran <salfra...@ipigto.rimed.cu> napsal(a):
> The package can be found on mentors.debian.net: > - URL: http://mentors.debian.net/debian/pool/main/l/libsockets++ > - Source repository: deb-src http://mentors.debian.net/debian unstable main > contrib non-free > - dget > http://mentors.debian.net/debian/pool/main/l/libsockets++/libsockets++_2.3.5-2.dsc Just quick review: - you add change license stuff in debian diff without any explanation - debian/rules contains lot of commented out things, it looks like this package is ideal candidate for minimal dh based debian/rules - please use patch system instead of directly patching sources - how did you choose soname for the library? what if upstream decides for different numbering later? - lintian -I --pendantic: I: libsockets++ source: debian-watch-file-is-missing I: libsockets++ source: binary-control-field-duplicates-source field "section" in package libsockets++2 P: libsockets++ source: direct-changes-in-diff-but-no-patch-system Ajp13Socket.cpp and 117 more -- Michal Čihař | http://cihar.com | http://blog.cihar.com
signature.asc
Description: PGP signature
