On Tue, Mar 31, 2009 at 10:48 PM, Sebastian Reichel wrote: > Please have a look again.
I'm not sponsoring new packages at the moment, but here is a review: If you haven't read libpkg-guide (and its two bugs), please do so. Please add symbols files. sed -i -e 's/documentary of/documentation for/' debian/control watch files contains unnessecary comments, blank lines & whitespace. Please think about the audience for each package, the lib package is usually only installed automatically and doesn't need much information. Same for the -common package. You might want to tell upstream about git2cl for generating the ChangeLog file. Please check if this line in the pkg-config file should not use Requires.private instead: Requires: gobject-2.0 clutter-0.8 You are missing copyright info from the tidy directory. There are several lintian complaints: lintian --display-info --display-experimental --pedantic --show-overrides --checksums --color auto *.dsc W: libchamplain source: dh-clean-k-is-deprecated W: libchamplain source: out-of-date-standards-version 3.8.0 (current is 3.8.1) I: libchamplain source: binary-control-field-duplicates-source field "section" in package libchamplain-0.2-1 I: libchamplain source: duplicate-short-description libchamplain-0.2-dev libchamplain-doc libchamplain-common libchamplain-0.2-1 W: libchamplain-gtk source: dh-clean-k-is-deprecated W: libchamplain-gtk source: out-of-date-standards-version 3.8.0 (current is 3.8.1) I: libchamplain-gtk source: binary-control-field-duplicates-source field "section" in package libchamplain-gtk-0.2-0 I: libchamplain-gtk source: duplicate-short-description libchamplain-gtk-doc libchamplain-gtk-0.2-dev libchamplain-gtk-0.2-0 Some binary package lintian complaints: I: libchamplain-0.2-1: no-symbols-control-file usr/lib/libchamplain-0.2.so.1.0.3 P: libchamplain-0.2-1: copyright-refers-to-symlink-license usr/share/common-licenses/LGPL I: libchamplain-0.2-1: copyright-with-old-dh-make-debian-copyright Some dpkg-shlibs warnings: dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if "debian/libchamplain-0.2-1/usr/lib/libchamplain-0.2.so.1.0.3" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgio-2.0.so.0 could be avoided if "debian/libchamplain-0.2-1/usr/lib/libchamplain-0.2.so.1.0.3" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpango-1.0.so.0 could be avoided if "debian/libchamplain-0.2-1/usr/lib/libchamplain-0.2.so.1.0.3" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgmodule-2.0.so.0 could be avoided if "debian/libchamplain-0.2-1/usr/lib/libchamplain-0.2.so.1.0.3" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgthread-2.0.so.0 could be avoided if "debian/libchamplain-0.2-1/usr/lib/libchamplain-0.2.so.1.0.3" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpangocairo-1.0.so.0 could be avoided if "debian/libchamplain-0.2-1/usr/lib/libchamplain-0.2.so.1.0.3" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgdk-x11-2.0.so.0 could be avoided if "debian/libchamplain-0.2-1/usr/lib/libchamplain-0.2.so.1.0.3" were not uselessly linked against it (they use none of its symbols). There is one GCC warning you might want to tell upstream about: gcc -DHAVE_CONFIG_H -I. -I.. -D_REENTRANT -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/clutter-0.8 -I/usr/include/clutter-0.8/clutter-cairo -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -DDATADIR=\"/usr/share\" -I../tidy -I.. -DCHAMPLAIN_COMPILATION -g -O2 -MT oam.lo -MD -MP -MF .deps/oam.Tpo -c sources/oam.c -o oam.o >/dev/null 2>&1 tile.c: In function 'tile_load': tile.c:217: warning: passing argument 3 of 'soup_session_queue_message' from incompatible pointer type -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
