Le Saturday 02 August 2008 00:40:41 Matthew Johnson, vous avez écrit : > On Tue Jul 29 19:29, Damien Raude-Morvan wrote: > > I would be glad if someone uploaded this package for me. > > Hi Damian, > > I've had a look over your package and may be able to sponsor it. I have > a few comments first though, and I agree with the comments on short > descriptions.
Hi, Thank for taking care of this :) > - changelog: since it's not been uploaded to Debian yet, can you > combine the changelog entries into just one. Pretty much changelog > entries should correspond to uploads (and obviously the debian revision > will be 1) It has been uploaded to my personnal debian repository and maybe (and _had been_, regarding Apache and FTP logs) installed by some debian users. Using -1 for first Debian upload don't seems enforced by debian-policy and I prefer keeping history of want has been uploaded to mentors and to my personnal repository. Did you agree with that ? > - Licence for the packaging: you say it is licenced under the 'GPL'. > You should give the version of the GPL and note that the Apache licence > is not compatible with the GPLv2[0]. In general it is recommended for > packaging to be the same licence as the package, or a permissive one > such as BSD or X11/expat. I've updated debian/copyright to licence Debian packaging under BSD licence which is more lenient witch Apache Mina licence. > - .vsd files: There seem to be a number of files under core/src/doc which > file(1) claims are Microsoft office documents. Are these used for > anything? Given you are stripping the tarball anyway you could probably > remove them? You're right, I've stripped them from orig.tar.gz tarballs (via debian/rules get-orig-source) > - Other licence files: I assume these apply to the jars you stripped > out? It's not required, but it might be nice to strip them too to avoid > confusion as to why they aren't in debian/copyright Idem, I've stripped this licences files. > Both packages build and are lintian/pbuilder clean though, which is > good. I've upload a new version on m.d.o : http://mentors.debian.net/debian/pool/main/m/mina/ Cheers, -- Damien Raude-Morvan / www.drazzib.com
signature.asc
Description: This is a digitally signed message part.
