On Tue Jul 29 19:29, Damien Raude-Morvan wrote: > > I would be glad if someone uploaded this package for me. > Hi Damian,
I've had a look over your package and may be able to sponsor it. I have a few comments first though, and I agree with the comments on short descriptions. - changelog: since it's not been uploaded to Debian yet, can you combine the changelog entries into just one. Pretty much changelog entries should correspond to uploads (and obviously the debian revision will be 1) - Licence for the packaging: you say it is licenced under the 'GPL'. You should give the version of the GPL and note that the Apache licence is not compatible with the GPLv2[0]. In general it is recommended for packaging to be the same licence as the package, or a permissive one such as BSD or X11/expat. - .vsd files: There seem to be a number of files under core/src/doc which file(1) claims are Microsoft office documents. Are these used for anything? Given you are stripping the tarball anyway you could probably remove them? - Other licence files: I assume these apply to the jars you stripped out? It's not required, but it might be nice to strip them too to avoid confusion as to why they aren't in debian/copyright I've also had a look at sqlline: - if (as README.Debian suggests) it is only useful with a jdbc driver it should probably depend (or at the very least recommend) a jdbc driver. I'd Depend on all of them as alternatives (those that are packaged). - debian/copyright claims BSD licence, but the LICENSE in the tarball says GPLv2, which is it? Both packages build and are lintian/pbuilder clean though, which is good. Matt 0. http://www.fsf.org/licensing/licenses/ -- Matthew Johnson
signature.asc
Description: Digital signature
