On Sun, May 25, 2008 at 01:53:33PM +0800, Vern Sun wrote: > I am looking for a sponsor for my package "vidalia".
Hi Vern, I’m not a DD, some comments nonetheless. > * Package name : vidalia > Version : 0.1.2-2~b2 > Upstream Author : Matt Edman <[EMAIL PROTECTED]>, Justin Hipple <[EMAIL > PROTECTED]> > * URL : http://www.vidalia-project.net/index.php > * License : GPLv2 > Section : x11 * As far as my understanding goes, the x11 section should only contain software that has to do with running X, like the X server itself, basic utilities, window managers, etc. I would have suggested putting vidalia into the same section as tor, but I believe that this one is also in the wrong section (comm). So, I’d put vidalia into net; I’ll file a bug on tor to get it there, too. > It builds these binary packages: > vidalia - controller GUI for Tor software. > > Vidalia allows you to start and stop Tor, view the status of Tor at a glance, > and monitor Tor's bandwidth usage. Vidalia also makes it easy to contribute > to > the Tor network by helping you setup a Tor server, if you wish. > > The package appears to be lintian clean. * “lintian -iI” does show a warning that XS-Vcs-* fields are deprecated, having been superseded by Vcs-*. You should probably remove them entirely, anyway: 6.2.5.2 Vcs-* Value of this field should be a string identifying unequivocally the location of the Version Control System repository used to maintain the given package, if available. -- http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s-bpp-vcs I.e., this should not be used to point to upstream’s repo. * Move Homepage: up to the source stanza. * Indicate why you close #405431 in debian/changelog (something along the lines of “Initial upload to the Debian archive”). Cheers, -- Michael Schutte <[EMAIL PROTECTED]>
signature.asc
Description: Digital signature
