Hello, On Dec 17, 2007 8:20 PM, Bas Wijnen <[EMAIL PROTECTED]> wrote: > On Mon, Dec 17, 2007 at 07:39:18PM +0800, LI Daobing wrote: > > The last upstream version has some license issue(relicense GPL code as > > LGPL), and this version have fix this problem. please help upload it, > > thanks. > > Some comments: > > Upstream appearantly changed the license headers. That's good. > However, they changed the FSF's address from really old (675 Mass Ave, > Cambridge) to old (59 Temple Place, Suite 330, Boston). It should be 51 > Franklin Street, Fifth Floor, Boston. You should tell this to upstream > (there's no need to change it yourself IMO, you can wait for upstream to > fix it). > > Note that GPL-3 doesn't suggest to put any address there anymore; > upstream could also consider using the GPL-3 template with the 3 changed > to a 2. IANAL though, so this may be a bad suggestion. ;-) > > In debian/copyright, all files are now (correctly) marked as GPL-2+. > However, you still point to /usr/share/common-licenses/LGPL-2 (three > times). > > debian/doc-base contains: > Author: <insert document author here> > I think you should do what it says. ;-) > > For the rest, it looks fine. >
I have upload a new version to mentors, fix all problems which you mentioned above, please check it, thanks. --------------------------------------------------------------------- The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/l/lunar-applet - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/lunar-applet/lunar-applet_1.8-1.dsc -- Best Regards, LI Daobing -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
