On Mon, Dec 17, 2007 at 07:39:18PM +0800, LI Daobing wrote: > The last upstream version has some license issue(relicense GPL code as > LGPL), and this version have fix this problem. please help upload it, > thanks.
Some comments: Upstream appearantly changed the license headers. That's good. However, they changed the FSF's address from really old (675 Mass Ave, Cambridge) to old (59 Temple Place, Suite 330, Boston). It should be 51 Franklin Street, Fifth Floor, Boston. You should tell this to upstream (there's no need to change it yourself IMO, you can wait for upstream to fix it). Note that GPL-3 doesn't suggest to put any address there anymore; upstream could also consider using the GPL-3 template with the 3 changed to a 2. IANAL though, so this may be a bad suggestion. ;-) In debian/copyright, all files are now (correctly) marked as GPL-2+. However, you still point to /usr/share/common-licenses/LGPL-2 (three times). debian/doc-base contains: Author: <insert document author here> I think you should do what it says. ;-) For the rest, it looks fine. Thanks, Bas -- I encourage people to send encrypted e-mail (see http://www.gnupg.org). If you have problems reading my e-mail, use a better reader. Please send the central message of e-mails as plain text in the message body, not as HTML and definitely not as MS Word. Please do not use the MS Word format for attachments either. For more information, see http://pcbcn10.phys.rug.nl/e-mail.html
signature.asc
Description: Digital signature
