On Fri, 2025-02-14 at 16:30 +0000, Phil Wyett wrote:
> Control: tags -1 +moreinfo
> 
> On Fri, 2025-02-14 at 12:44 +0100, itd wrote:
> > Control: tags -1 - moreinfo
> > 
> > Hi,
> > 
> > Phil Wyett <philip.wy...@kathenas.org> writes:
> > 
> > > Thank you for taking the time to prepare this package and your ongoing
> > > contribution to the Debian project.
> > 
> > and thank you once more for the review and feedback.
> > 
> > > Test 8 Fail Summary
> > > ===================
> > > 
> > > philwyett@ks-calrissian:~/Downloads$ notifymuch 
> > > philwyett@ks-calrissian:~/Downloads$ Traceback (most recent call last):
> > >   File "/usr/lib/python3/dist-packages/notifymuch/notification.py", line
> > > 52, in
> > > on_activate
> > >     messages = Messages()
> > >   File "/usr/lib/python3/dist-packages/notifymuch/messages.py", line 122,
> > > in
> > > __init__
> > >     db = notmuch.Database()
> > >   File "/usr/lib/python3/dist-packages/notmuch/database.py", line 160, in
> > > __init__
> > >     Database._std_db_path = self._get_user_default_db()
> > >                             ~~~~~~~~~~~~~~~~~~~~~~~~~^^
> > >   File "/usr/lib/python3/dist-packages/notmuch/database.py", line 674, in
> > > _get_user_default_db
> > >     config.readfp(codecs.open(conf_f, 'r', 'utf-8'))
> > >                   ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
> > >   File "<frozen codecs>", line 921, in open
> > > FileNotFoundError: [Errno 2] No such file or directory:
> > > '/home/philwyett/.notmuch-config'
> > 
> > I am assuming that the test is considered a failure since the program
> > terminated with an exception.  Was notmuch configured on that machine?
> > If not, then I would consider this outcome not a failure (even though a
> > nicely formatted error message might be more appealing).
> > 
> > The package now Enhances/Recommends notmuch, contains a brief manpage,
> > and ships upstream's README.rst with expected first steps.  None of this
> > will ensure that users configure notmuch first, but it might help them
> > figure out how to use this software.
> > 
> > Best regards
> > itd
> 
> Hi itd,
> 
> Does this package require 'notmuch'? If so, is it a 'Depends' or 'Suggests'.
> 

Missed 'Recommends' from the list.

> Failures should have a friendly user readable and understandable message and
> then help. This is something you may wish to look at in future uploads?
> 
> Regards
> 
> Phil
> 

Regards

Phil

-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to