Control: tags -1 +confirmed Ahmad,
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information only
Running lintian...
N:
I: golang-github-binwiederhier-ntfy source: missing-built-using-field-for-
golang-package (in section for ntfy) [debian/control:32]
N:
N: The stanza for a Golang installation package in the debian/control file
N: does not include a Built-Using field that contains the ${misc:Built-Using}
N: substitution variable.
N:
N: The dh_golang(1) build system provides the ${misc:Built-Using} variable.
N: It is used when scheduling binNMUs.
N:
N: Please add the following line to the relevant stanza:
N:
N: Built-Using: ${misc:Built-Using}
N:
N: Visibility: info
N: Show-Always: no
N: Check: languages/golang/built-using
N:
I: Lintian run was successful.
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Summary...
Again, very responsive and excellent work. I think you will an asset to the Go
Team.
I believe golang-github-binwiederhier-ntfy is ready for review/possible
sponsorship. Could a Debian Developer (DD) with available free time, please
review this package and upload if you feel it is ready and appropriate for the
distribution.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
Donations...
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Liberapay: https://liberapay.com/kathenas
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Wiki: https://wiki.kathenas.org
Instagram: https://instagram.com/kathenasorg
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
