Control: retitle 1078571 ITP: ntfy -- Send push notifications to device Control: tags -1 +moreinfo
Ahmad,
Going to try retitle from here what was the RFP that was incorrectly retitled
to an Intent To Adopt (ITA). Going to change to Intent To Package (ITP). If it
doesn't work I will change it via bts CLI.
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
I: golang-github-binwiederhier-ntfy source: duplicate-short-description heckel-
ntfy-v2-dev ntfy [debian/control]
N:
N: The listed binary packages all share the same short description, i.e. the
N: first line of the Description field in debian/control.
N:
N: Please add a word or two, in parentheses if needed, to describe to users
N: what they are installing.
N:
N: It is not okay to rely solely on package naming conventions to indicate
N: what is inside.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/control/field/description/duplicate
N:
N:
I: heckel-ntfy-v2-dev: extra-license-file
[usr/share/gocode/src/heckel.io/ntfy/LICENSE.GPLv2]
N:
N: All license information should be collected in the debian/copyright file.
N: This usually makes it unnecessary for the package to install this
N: information in other places as well.
N:
N: Please refer to Copyright information (Section 12.5) in the Debian Policy
N: Manual for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: files/licenses
N:
N:
I: heckel-ntfy-v2-dev: extra-license-file
[usr/share/gocode/src/heckel.io/ntfy/LICENSE]
N:
I: golang-github-binwiederhier-ntfy source: missing-built-using-field-for-
golang-package (in section for ntfy) [debian/control:32]
N:
N: The stanza for a Golang installation package in the debian/control file
N: does not include a Built-Using field that contains the ${misc:Built-Using}
N: substitution variable.
N:
N: The dh_golang(1) build system provides the ${misc:Built-Using} variable.
N: It is used when scheduling binNMUs.
N:
N: Please add the following line to the relevant stanza:
N:
N: Built-Using: ${misc:Built-Using}
N:
N: Visibility: info
N: Show-Always: no
N: Check: languages/golang/built-using
N:
N:
I: golang-github-binwiederhier-ntfy source: out-of-date-standards-version 4.6.2
(released 2022-12-17) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
N:
N:
I: heckel-ntfy-v2-dev: package-contains-documentation-outside-usr-share-doc
[usr/share/gocode/src/heckel.io/ntfy/CODE_OF_CONDUCT.md]
N:
N: This package ships a documentation file outside /usr/share/doc
N: Documentation files are normally installed inside /usr/share/doc.
N:
N: If this file doesn't describe the contents or purpose of the directory it
N: is in, please consider moving this file to /usr/share/doc/ or maybe even
N: removing it. If this file does describe the contents or purpose of the
N: directory it is in, please add a lintian override.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation
N:
N: Screen: python/egg/metadata
N: Advocates: "Scott Kitterman" <deb...@kitterman.com>
N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N: Python modules. Those files are not documentation even though
N: some of their names carry the .txt file extension.
N:
N: Python modules can be both public and private.
N:
N: Read more in
N:
https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N: https://www.python.org/dev/peps/pep-0376/#id16,
N: https://www.python.org/dev/peps/pep-0610/,
N: https://www.python.org/dev/peps/pep-0639/,
N:
https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N: and Bug#1003913.
N:
N:
I: heckel-ntfy-v2-dev: package-contains-documentation-outside-usr-share-doc
[usr/share/gocode/src/heckel.io/ntfy/LICENSE]
N:
I: heckel-ntfy-v2-dev: package-contains-documentation-outside-usr-share-doc
[usr/share/gocode/src/heckel.io/ntfy/README.md]
N:
I: heckel-ntfy-v2-dev: package-contains-documentation-outside-usr-share-doc
[usr/share/gocode/src/heckel.io/ntfy/SECURITY.md]
N:
I: heckel-ntfy-v2-dev: package-contains-documentation-outside-usr-share-doc
[usr/share/gocode/src/heckel.io/ntfy/requirements.txt]
N:
I: heckel-ntfy-v2-dev: package-contains-documentation-outside-usr-share-doc
[usr/share/gocode/src/heckel.io/ntfy/server/site/app.html]
N:
I: heckel-ntfy-v2-dev: package-contains-documentation-outside-usr-share-doc
[usr/share/gocode/src/heckel.io/ntfy/util/embedfs/test.txt]
N:
I: ntfy: spelling-error-in-binary Quiting Quitting [usr/bin/ntfy]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
I: ntfy: spelling-error-in-binary octects octets [usr/bin/ntfy]
N:
I: ntfy: spelling-error-in-binary unkown unknown [usr/bin/ntfy]
N:
I: ntfy: spelling-error-in-binary wtH with [usr/bin/ntfy]
N:
I: ntfy: systemd-service-file-missing-documentation-key
[usr/lib/systemd/system/ntfy-client.service]
N:
N: The systemd service file does not contain a Documentation key.
N:
N: Documentation for systemd service files can be automatically viewed using
N: systemctl help servicename if this field is present.
N:
N: Please refer to the systemd.unit(5) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: systemd
N:
N:
I: ntfy: systemd-service-file-missing-documentation-key
[usr/lib/systemd/system/ntfy.service]
I: Lintian run was successful.
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Not performed at this time
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Summary...
I believe golang-github-binwiederhier-ntfy is not yet ready for sponsorship at
this time. Could the contributor rectify one of more of the raised issues.
Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
Donations...
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Liberapay: https://liberapay.com/kathenas
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Wiki: https://wiki.kathenas.org
Instagram: https://instagram.com/kathenasorg
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
