Control: tags -1 -moreinfo
Hello, On 27/11/2024 11:20, Jeroen Ploemen wrote:
Control: tags -1 moreinfo On Tue, 26 Nov 2024 18:38:55 -0300 Lucas Castro <lu...@gnuabordo.com.br> wrote:I am looking for a sponsor for my package lsm:hi Lucas, took a look at the package, and some issues came up:
I had uploaded to mentors a reworked packaging of lsm.
* copyright: years are outdated for both packaging and upstream.
* changelog: revision 1.0.21-1.1 is missing, please restore.
* control:
+ build logs [1] suggest the program is only compatible with
systems running a linux kernel; if so, the Architecture field
should reflect that (i.e., set to 'linux-any').
Done and really thanks.
+ useless (and incorrectly versioned) build-dep on debhelper, not
needed at all with debhelper-compat.
Right now only debhelper-compat on build-dep.
+ why the (undocumented!) bump of the versioning of the
conflicts/replaces?
Fixed.
+ field Rules-Requires-Root is missing.
Had been added.
+ build-dep on docbook-to-man could be marked <!nodoc>.
Appended.
* init script:
+ exits nonzero if the executable isn't installed anymore, should
handle that condition gracefully as this is the expected
situation if the package gets uninstalled. The script and
associated files under /etc are configuration files, which are
left alone in a regular uninstall and only removed if the package
is purged.
+ usage info list a 'restart' option, but the script doesn't
actually implement one.
had been implemented.
Not required, it'll be used by derivative system. I really expected not be required right now.+ INIT INFO 'Provides' entry is missing. + INIT INFO 'Description' is empty/boilerplate.
* rules: doesn't respect 'nodoc' build profile. See [2] for examples to make the documentation build conditional.
nodoc had been append to build-depends field but not used as expected,the nodoc is used for doc target build system, when the source provides a target build to get the doc built.
Build-depends related to the doc is used just to convert/compile a sgml file to man page that I had wrote by myself, a manual file to feed the man command.
* watch: please change the URL to https.
had been changed.
* d/upstream: + that changelog file is way out of date.
updated.
+ metadata file is missing. [3]
Upstream doesn't provides information to fit on that.
[1]https://buildd.debian.org/status/package.php?p=lsm [2]https://codesearch.debian.net/search?q=path%3Adebian%2Frules+filter+nodoc&literal=1 [3]https://udd.debian.org/lintian-tag/upstream-metadata-file-is-missing Please remove the moreinfo tag (and CC me) once you have an updated package ready.
Thanks, Lucas Castro
OpenPGP_0x42F79A5E0A4D5598.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
