On 27/11/2024 13:43, Lucas Castro wrote:
On 27/11/2024 11:20, Jeroen Ploemen wrote:Control: tags -1 moreinfo On Tue, 26 Nov 2024 18:38:55 -0300 Lucas Castro <lu...@gnuabordo.com.br> wrote:I am looking for a sponsor for my package lsm:hi Lucas, took a look at the package, and some issues came up: * copyright: years are outdated for both packaging and upstream.That's true.due the * changelog: revision 1.0.21-1.1 is missing, please restore.That's because of source-only upload made by the debian sponsor upload,so that was not tracked by cvs, That seems like you require some Debian upload being tracked by CVs.version 1.0.21-1.1 wasn't proposed by me, it happened for some debian requirement, like secure upload that due the package for auto-rebuild.* control: + build logs [1] suggest the program is only compatible with systems running a linux kernel; if so, the Architecture field should reflect that (i.e., set to 'linux-any').Well noted.+ useless (and incorrectly versioned) build-dep on debhelper, not needed at all with debhelper-compat.But it's still useful somehow. debhelper maintain debhelper-compat on d/control Provides fields, But I can't ensure that's true for all derivatives Debian systems.+ why the (undocumented!) bump of the versioning of the conflicts/replaces?That's so common for transitional package thus I hadn't done but I can do it.+ field Rules-Requires-Root is missing. + build-dep on docbook-to-man could be marked <!nodoc>.I must review this option.I don't know if I really got this, but there's a dh-maintscript to update the configfile path.* init script: + exits nonzero if the executable isn't installed anymore, should handle that condition gracefully as this is the expected situation if the package gets uninstalled. The script and associated files under /etc are configuration files, which are left alone in a regular uninstall and only removed if the package is purged.+ usage info list a 'restart' option, but the script doesn't actually implement one.Yep, It must be provided.+ INIT INFO 'Provides' entry is missing. + INIT INFO 'Description' is empty/boilerplate.INIT INFO is recommend but not required, and I really take a time to review this, but as that's just for derivatives using sysv init thus I didn't waste time on this.* rules: doesn't respect 'nodoc' build profile. See [2] for examples to make the documentation build conditional. * watch: please change the URL to https.Upstream doesn't provides one.
I rechecked that, the Upstream provides it by now, I'll update.
* d/upstream: + that changelog file is way out of date.That one comes from foolsm.spec and I really don't have a clue why is out of date.+ metadata file is missing. [3] [1]https://buildd.debian.org/status/package.php?p=lsm[2]https://codesearch.debian.net/search?q=path%3Adebian%2Frules+filter+nodoc&literal=1[3]https://udd.debian.org/lintian-tag/upstream-metadata-file-is-missing Please remove the moreinfo tag (and CC me) once you have an updated package ready.
OpenPGP_0x42F79A5E0A4D5598.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
