Control: tags -1 +moreinfo

Willem,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Issue, autopkgtest

Setting up xsnow (1:3.8.0-1) ...
Processing triggers for libc-bin (2.40-4) ...
autopkgtest [11:09:26]: test test1.sh: [-----------------------
PASSED: running xsnow -h
autopkgtest [11:09:26]: test test1.sh: -----------------------]
autopkgtest [11:09:26]: test test1.sh:  - - - - - - - - - - results - - - - -
- - - - -
test1.sh             PASS
autopkgtest [11:09:26]: test test2.sh: preparing testbed
Ign:1 file:/tmp/autopkgtest.O97wSh/binaries  InRelease
Get:2 file:/tmp/autopkgtest.O97wSh/binaries  Release [816 B]
Get:2 file:/tmp/autopkgtest.O97wSh/binaries  Release [816 B]
Ign:3 file:/tmp/autopkgtest.O97wSh/binaries  Release.gpg
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 0 not upgraded.
Need to get 0 B/1854 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 file:/tmp/autopkgtest.O97wSh/binaries  xsnow 1:3.8.0-1 [1854 kB]
debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
(Reading database ... 18056 files and directories currently installed.)
Preparing to unpack .../binaries/./xsnow.deb ...
Unpacking xsnow (1:3.8.0-1) over (1:3.8.0-1) ...
Setting up xsnow (1:3.8.0-1) ...
W: --force-yes is deprecated, use one of the options starting with --allow
instead.
Reading package lists...
Building dependency tree...
Reading state information...
Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
autopkgtest [11:09:30]: test test2.sh: [-----------------------
Not found: Xvfb
Not found: xdotool
Not found: scrot
Not found: xdpyinfo
/tmp/autopkgtest.O97wSh/build.th7/src/debian/tests/test2.sh FAILED because of
missing program(s)
autopkgtest [11:09:30]: test test2.sh: -----------------------]
autopkgtest [11:09:30]: test test2.sh:  - - - - - - - - - - results - - - - -
- - - - -
test2.sh             FAIL non-zero exit status 1
autopkgtest [11:09:30]: @@@@@@@@@@@@@@@@@@@@ summary
test1.sh             PASS
test2.sh             FAIL non-zero exit status 1

E: Autopkgtest run failed.

2. Lintian [3]: Good

3. Licenses [4]: Issue, always chance of false positives

philwyett@ks-tarkin:~/Development/builder/debian$ dpkg-source -x xsnow_3.8.0-
1.dsc 
dpkg-source: warning: extracting unsigned source package (xsnow_3.8.0-1.dsc)
dpkg-source: info: extracting xsnow in xsnow-3.8.0
dpkg-source: info: unpacking xsnow_3.8.0.orig.tar.gz
dpkg-source: info: unpacking xsnow_3.8.0-1.debian.tar.xz
philwyett@ks-tarkin:~/Development/builder/debian$ cd xsnow-3.8.0/
philwyett@ks-tarkin:~/Development/builder/debian/xsnow-3.8.0$ lrc
en: Versions: recon 3.1  check 3.3.9-1

Parsing Source Tree  ....
Reading d/copyright  ....
  Missing Files: Paragraph for debian/
Running licensecheck ....

d/copyright      | licensecheck

GPL-3+           | FSFULLR           config.rpath
GPL-3+           | FSFAP             INSTALL
GPL-3+           | FSFAP             po/remove-potcdate.sin
MIT              | HPND-sell-variant and/or NTP~disclaimer src/clientwin.c
MIT              | HPND-sell-variant and/or NTP~disclaimer src/clientwin.h
GPL-3+           | LGPL-2.1+         src/gettext.h

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good

6. Reproducible builds [5]: Issue, None blocking

Something to be looked at in the future I would hope.

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

<Summary...

I believe 'xsnow' is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug
report.REPLACE_WITH_SUMMARY>

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Liberapay: https://liberapay.com/kathenas

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Wiki: https://wiki.kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--












Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to