Control: tags -1 +moreinfo Willem,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Information only Running lintian... N: W: xsnow: appstream-metadata-validation-failed Problems reported by "appstreamcli validate-tree". N: N: The specified AppStream metadata file fail to validate using 'appstreamcli N: validate-tree --no-net path-to-package-root'. N: N: Please refer to https://wiki.debian.org/AppStream/Guidelines for details. N: N: Visibility: warning N: Show-Always: no N: Check: appstream-metadata N: N: I: xsnow source: superficial-tests [debian/tests/control] N: N: The source package declares tests in the debian/tests/control file but N: provides only tests with a superficial restriction. N: N: Please provide more meaningful tests. N: N: Please refer to N: https://lists.debian.org/debian-devel-announce/2019/08/msg00003.html, N: Bug#932870, and N: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst N: for details. N: N: Visibility: info N: Show-Always: no N: Check: testsuite N: N: P: xsnow source: silent-on-rules-requiring-root [debian/control] N: N: The field Rules-Requires-Root is missing from the file debian/control. N: N: Over time, Debian has successively narrowed the steps for which elevated N: privileges are required. It speeds up the building of installation N: packages in the archive. Eventually, Debian will switch the default N: archive-wide behaviour to expedite the build process further. N: N: Please declare explicitly that the sources do not require root privileges. N: You can use the setting Rules-Requires-Root: no in the source stanza of N: debian/control, but please verify with diffoscope(1) that the installation N: packages produced are in fact identical. N: N: Please refer to usr/share/doc/dpkg/spec/rootless-builds.txt, debian/rules N: and Rules-Requires-Root (Section 4.9.2) in the Debian Policy Manual, and N: Rules-Requires-Root (Section 5.6.31) in the Debian Policy Manual for N: details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/control/field/rules-requires-root N: Renamed from: rules-requires-root-missing N: I: Lintian run was successful. 3. Licenses [4]: Issue, possibility of false positives philwyett@ks-tarkin:~/Development/builder/debian/xsnow-3.7.9$ lrc en: Versions: recon 3.0 check 3.3.9-1 Parsing Source Tree .... Reading d/copyright .... Missing Files: Paragraph for debian/ Running licensecheck .... d/copyright | licensecheck GPL-3+ | GPL afterburner/Makefile.am GPL-3+ | GPL afterburner/Makefile.in GPL-3+ | GPL bootstrap GPL-3+ | FSFULLR config.rpath GPL-3+ | GPL debian/changelog GPL-3+ | GPL debian/tests/test1.sh GPL-3+ | GPL debian/tests/test2.sh GPL-3+ | FSFAP INSTALL GPL-3+ | GPL Makefile.am GPL-3+ | FSFAP po/remove-potcdate.sin GPL-3+ | GPL simplemake.sh GPL-3+ | GPL src/aurora.c GPL-3+ | GPL src/aurora.h GPL-3+ | GPL src/birdglobals.h GPL-3+ | GPL src/birds.c GPL-3+ | GPL src/birds.h GPL-3+ | GPL src/blowoff.c GPL-3+ | GPL src/blowoff.h GPL-3+ | GPL src/buttons.h GPL-3+ | GPL and/or HPND-sell-variant and/or NTP~disclaimer src/clientwin.c GPL-3+ | GPL and/or HPND-sell-variant and/or NTP~disclaimer src/clientwin.h GPL-3+ | GPL src/clocks.c GPL-3+ | GPL src/clocks.h GPL-3+ | GPL src/csvpos.c GPL-3+ | GPL src/csvpos.h GPL-3+ | GPL src/debug.h GPL-3+ | GPL src/docs.c GPL-3+ | GPL src/docs.h GPL-3+ | GPL src/doitb.h GPL-3+ | GPL src/doit.h GPL-3+ | GPL and/or MIT-Open-Group src/dsimple.c GPL-3+ | GPL and/or MIT-Open-Group src/dsimple.h GPL-3+ | GPL src/fallensnow.c GPL-3+ | GPL src/fallensnow.h GPL-3+ | GPL src/flags.c GPL-3+ | GPL src/flags.h GPL-3+ | GPL src/gen_snow_includes.sh GPL-3+ | GPL src/gen_ui_xml.sh GPL-3+ | LGPL-2.1+ src/gettext.h GPL-3+ | GPL src/hashtable.cpp GPL-3+ | GPL src/hashtable.h GPL-3+ | GPL src/ixpm.c GPL-3+ | GPL src/ixpm.h GPL-3+ | BSD-3-clause and/or GPL src/kdtree.c GPL-3+ | BSD-3-clause and/or GPL src/kdtree.h GPL-3+ | GPL src/loadmeasure.c GPL-3+ | GPL src/loadmeasure.h GPL-3+ | GPL src/main.c GPL-3+ | GPL src/mainstub.cpp GPL-3+ | GPL src/mainstub.h GPL-3+ | GPL src/Makefile.am GPL-3+ | GPL src/makeman.c GPL-3+ | GPL src/meteor.c GPL-3+ | GPL src/meteor.h GPL-3+ | GPL src/moon.c GPL-3+ | GPL src/moon.h GPL-3+ | GPL src/mygettext.h GPL-3+ | GPL src/Pixmaps/AltSanta1.xpm GPL-3+ | GPL src/Pixmaps/AltSanta2.xpm GPL-3+ | GPL src/Pixmaps/AltSanta3.xpm GPL-3+ | GPL src/Pixmaps/AltSanta4.xpm GPL-3+ | GPL src/Pixmaps/AltSantaRudolf1.xpm GPL-3+ | GPL src/Pixmaps/AltSantaRudolf2.xpm GPL-3+ | GPL src/Pixmaps/AltSantaRudolf3.xpm GPL-3+ | GPL src/Pixmaps/AltSantaRudolf4.xpm GPL-3+ | GPL src/Pixmaps/BigSanta1.xpm GPL-3+ | GPL src/Pixmaps/BigSanta2.xpm GPL-3+ | GPL src/Pixmaps/BigSanta3.xpm GPL-3+ | GPL src/Pixmaps/BigSanta4.xpm GPL-3+ | GPL src/Pixmaps/BigSanta81.xpm GPL-3+ | GPL src/Pixmaps/BigSanta82.xpm GPL-3+ | GPL src/Pixmaps/BigSanta83.xpm GPL-3+ | GPL src/Pixmaps/BigSanta84.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf1.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf2.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf3.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf4.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf81.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf82.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf83.xpm GPL-3+ | GPL src/Pixmaps/BigSantaRudolf84.xpm GPL-3+ | GPL src/Pixmaps/bird1.xpm GPL-3+ | GPL src/Pixmaps/bird2.xpm GPL-3+ | GPL src/Pixmaps/bird3.xpm GPL-3+ | GPL src/Pixmaps/bird4.xpm GPL-3+ | GPL src/Pixmaps/bird5.xpm GPL-3+ | GPL src/Pixmaps/bird6.xpm GPL-3+ | GPL src/Pixmaps/bird7.xpm GPL-3+ | GPL src/Pixmaps/bird8.xpm GPL-3+ | GPL src/Pixmaps/birdd1.xpm GPL-3+ | GPL src/Pixmaps/birdd2.xpm GPL-3+ | GPL src/Pixmaps/birdd3.xpm GPL-3+ | GPL src/Pixmaps/birdd4.xpm GPL-3+ | GPL src/Pixmaps/birdd5.xpm GPL-3+ | GPL src/Pixmaps/birdd6.xpm GPL-3+ | GPL src/Pixmaps/birdd7.xpm GPL-3+ | GPL src/Pixmaps/birdd8.xpm GPL-3+ | GPL src/Pixmaps/birdl1.xpm GPL-3+ | GPL src/Pixmaps/birdl2.xpm GPL-3+ | GPL src/Pixmaps/birdl3.xpm GPL-3+ | GPL src/Pixmaps/birdl4.xpm GPL-3+ | GPL src/Pixmaps/birdl5.xpm GPL-3+ | GPL src/Pixmaps/birdl6.xpm GPL-3+ | GPL src/Pixmaps/birdl7.xpm GPL-3+ | GPL src/Pixmaps/birdl8.xpm GPL-3+ | GPL src/pixmaps.c GPL-3+ | GPL src/Pixmaps/eland.xpm GPL-3+ | GPL src/Pixmaps/extratree.xpm GPL-3+ | GPL src/Pixmaps/flake0.xpm GPL-3+ | GPL src/Pixmaps/flake1.xpm GPL-3+ | GPL src/Pixmaps/flake2.xpm GPL-3+ | GPL src/Pixmaps/flake3.xpm GPL-3+ | GPL src/Pixmaps/flake4.xpm GPL-3+ | GPL src/Pixmaps/flake5.xpm GPL-3+ | GPL src/Pixmaps/flake6.xpm GPL-3+ | GPL src/pixmaps.h GPL-3+ | GPL src/Pixmaps/huis4.xpm GPL-3+ | GPL src/Pixmaps/Makefile.am GPL-3+ | GPL src/Pixmaps/make.inc GPL-3+ | GPL src/Pixmaps/MediumSanta1.xpm GPL-3+ | GPL src/Pixmaps/MediumSanta2.xpm GPL-3+ | GPL src/Pixmaps/MediumSanta3.xpm GPL-3+ | GPL src/Pixmaps/MediumSanta4.xpm GPL-3+ | GPL src/Pixmaps/MediumSantaRudolf1.xpm GPL-3+ | GPL src/Pixmaps/MediumSantaRudolf2.xpm GPL-3+ | GPL src/Pixmaps/MediumSantaRudolf3.xpm GPL-3+ | GPL src/Pixmaps/MediumSantaRudolf4.xpm GPL-3+ | GPL src/Pixmaps/moon1.xpm GPL-3+ | GPL src/Pixmaps/moon2.xpm GPL-3+ | GPL src/Pixmaps/polarbear.xpm GPL-3+ | GPL src/Pixmaps/RegularSanta1.xpm GPL-3+ | GPL src/Pixmaps/RegularSanta2.xpm GPL-3+ | GPL src/Pixmaps/RegularSanta3.xpm GPL-3+ | GPL src/Pixmaps/RegularSanta4.xpm GPL-3+ | GPL src/Pixmaps/RegularSantaRudolf1.xpm GPL-3+ | GPL src/Pixmaps/RegularSantaRudolf2.xpm GPL-3+ | GPL src/Pixmaps/RegularSantaRudolf3.xpm GPL-3+ | GPL src/Pixmaps/RegularSantaRudolf4.xpm GPL-3+ | GPL src/Pixmaps/rendier.xpm GPL-3+ | GPL src/Pixmaps/snowtree.xpm GPL-3+ | GPL src/Pixmaps/star.xbm GPL-3+ | GPL src/Pixmaps/tannenbaum.xpm GPL-3+ | GPL src/Pixmaps/tree-1_100px.xpm GPL-3+ | GPL src/Pixmaps/tree.xpm GPL-3+ | GPL src/Pixmaps/xsnow41x30.xpm GPL-3+ | GPL src/Pixmaps/xsnow64x64.xpm GPL-3+ | GPL src/Pixmaps/xsnow.xpm GPL-3+ | GPL src/safe_malloc.h GPL-3+ | GPL src/Santa.c GPL-3+ | GPL src/Santa.h GPL-3+ | GPL src/scenery.c GPL-3+ | GPL src/scenery.h GPL-3+ | GPL src/selfrep.c GPL-3+ | GPL src/selfrep.h GPL-3+ | GPL src/snow.c GPL-3+ | GPL src/snow.h GPL-3+ | GPL src/snow_includes.h GPL-3+ | GPL src/spline_interpol.c GPL-3+ | GPL src/spline_interpol.h GPL-3+ | GPL src/stars.c GPL-3+ | GPL src/stars.h GPL-3+ | GPL src/test1.sh GPL-3+ | GPL src/toascii.sh GPL-3+ | GPL src/tocc.sh GPL-3+ | GPL src/transwindow.c GPL-3+ | GPL src/transwindow.h GPL-3+ | GPL src/treesnow.c GPL-3+ | GPL src/treesnow.h GPL-3+ | GPL src/ui.c GPL-3+ | GPL src/ui.h GPL-3+ | GPL src/undefall.inc GPL-3+ | GPL src/utils.c GPL-3+ | GPL src/utils.h GPL-3+ | GPL src/version.h GPL-3+ | GPL src/wind.c GPL-3+ | GPL src/wind.h GPL-3+ | GPL src/windows.c GPL-3+ | GPL src/windows.h GPL-3+ | GPL src/wmctrl.c GPL-3+ | GPL src/wmctrl.h GPL-3+ | BSD-3-clause src/xdo.c GPL-3+ | BSD-3-clause src/xdo.h GPL-3+ | BSD-3-clause src/xdo_util.h GPL-3+ | BSD-3-clause src/xdo_version.h GPL-3+ | GPL src/xsnow-constants.h GPL-3+ | GPL src/xsnow.h 4. Watch file [uscan --force-download]: 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Issue, none blocking Please see [5] to reproduce. 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... I believe xsnow is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
