control: tags 1084795 - moreinfo
Hi,
thank you for the review!
On 15/11/24 18:24, Tobias Frost wrote:
> Control: tags -1 moreinfo
>
> Hi,
>
> short review, ran out of time to complete it:
>
> - d/scripts/mohaa-server references /usr/lib/openmohaa/README.mohaa-
> data maybe it should directly mention the real location in
> /usr/share/doc/openmohaa/ ?
[done]
> - d/copyright,
> - the RSA-MD5 Section needs also copyright year 1991 (because of
> md5.h)
> - the RSA-MD4 also needs the years 1990-1992.
[done]
> - code/autoupdater/autoupdater.c is dual licensed, needs to be
> reflected in d/copyright ; same for code/sys/sys_autoupdater.c
I'm reluctant to do that because I copy/pasted the copyright block about
those files from src:ioquake3/copyright (they comes from ioq3) and i
don't thinks they really are "dual licensed";
they are just plain public-domain/"no copyright is claimed".
In ioq3 src I can read "The updater program's code is public domain. The
rest of ioquake3 is not."
And we do not build the autoupdater in Debian, so I don't think it
matters that much.
On 16/11/24 10:09, Tobias Frost wrote:
Control: owner -1 !
Hi,
Update, I've completed the review and I think after updating d/copyright
the package will be ready to be uploaded.
:-)
As this is a game, it would be great if you would consider putting it
into the games-team realm by adding the team ("Debian Games Team
<pkg-games-de...@lists.alioth.debian.org>") to the Maintainer field
and yourself to the Uploader field. (But that is totally up to you and
not a requirment.)
[done]
also same category:
please consider moving the repository out of your private namespace on
salsa; I can create you a mcds repo in the debian/ or games-team/
namespace and grant you all the required rights, please let me know.
(private repositories are a hinderance in collaborative maintainance.)
[done]
https://salsa.debian.org/games-team/openmohaa
I had right to create the repo, but it seems i'm lacking rights for
other stuffs, like I can't edit the project name/description (I do not
see the 'Settings' label in the menu on the left).
Feel free to poke me when you've updated the package.
package updated on mentors.debian.net and in the git repo :-)
Cheers and thanks for your contributions to Debian!
tobi
On 16/11/24 11:26, Tobias Frost wrote:
> One little thing:
>
> there is debian/openmohaa-server.purge
> I don't think that does anything, does it? (It would be indeed new to
> me if there are .purge files that do something and I'd love to learn
> about that, so please correct me if I missed that.)
it's a leftover that I forgot to remove once i had the correct bits in
place in the postrm script, thanks for spotting it ^^
br,
Sébastien
