Control: owner -1 !
Hi,
Update, I've completed the review and I think after updating d/copyright
the package will be ready to be uploaded.
As this is a game, it would be great if you would consider putting it
into the games-team realm by adding the team ("Debian Games Team
<pkg-games-de...@lists.alioth.debian.org>") to the Maintainer field
and yourself to the Uploader field. (But that is totally up to you and
not a requirment.)
also same category:
please consider moving the repository out of your private namespace on
salsa; I can create you a mcds repo in the debian/ or games-team/
namespace and grant you all the required rights, please let me know.
(private repositories are a hinderance in collaborative maintainance.)
Feel free to poke me when you've updated the package.
Cheers and thanks for your contributions to Debian!
tobi
On Fri, 15 Nov 2024 18:24:18 +0100 Tobias Frost <t...@debian.org> wrote:
> Control: tags -1 moreinfo
>
>
> Hi,
>
> short review, ran out of time to complete it:
>
> - d/scripts/mohaa-server references /usr/lib/openmohaa/README.mohaa-
data
> maybe it should directly mention the real location in
> /usr/share/doc/openmohaa/ ?
>
> - d/copyright,
> - the RSA-MD5 Section needs also copyright year 1991 (because of
> md5.h)
> - the RSA-MD4 also needs the years 1990-1992.
> - code/autoupdater/autoupdater.c is dual licensed, needs to be
> reflected in d/copyright ; same for code/sys/sys_autoupdater.c
>
>
>
>
>
