Control: tags -1 + moreinfo - confirmed On Thu, 10 Oct 2024 03:41:25 +0530 Sourav Bhattacharya <souravbhattacha...@tutamail.com> wrote:
> I am looking for a sponsor for my package python3-nextdns:
hi Sourav,
reviewed your package, and the following issues came up:
* the source package name should really be python-nextdns, not
python3-nextdns; the latter is the correct name for the binary
package only. The related lintian hit (triggered by the "python3" in
the source package name) is actually correct and should not be
overridden.
* control:
+ salsa git repository homeassistant-team/deps/nextdns either
doesn't exist or isn't public.
+ the repository name should match the source package name.
+ long description should be expanded to provide information about
what the module can do, e.g. does it provide the complete API or
just a subset, typical actions, supported/compatible services,
and so on. While "This package is a dependency of Home Assistant"
may be the reason for packaging it, that kind of info isn't really
useful in a package's description.
+ the ancient version requirement for the python3-aiohttp build-dep
can already be satisfied on oldstable and should be dropped.
+ tests aren't run on build, probably because of a missing explicit
build-dep on python3-pytest which makes pybuild fall back to
unittests discovery.
+ linters such as mypy and ruff are mostly useful for upstream
developers. With the current packaging, these build-deps don't
appear to be actually used at all and could be dropped.
* autopkgtest: d/tests/control looks like a verbatim copy of the
automagic pybuild autopkgtest. If you want to use that, better
remove all of d/tests and add the pybuild autopkgtest the intended
way by setting 'Testsuite: autopkgtest-pkg-pybuild' in d/control.
If you haven't already, please enable the CI on the salsa repository;
the standard recipe is fine.
See https://salsa.debian.org/salsa-ci-team/pipeline#activate-salsa-ci
Please remove the moreinfo tag (and put me in the CC) once you have
an updated package ready.
pgp4XsGF2frqs.pgp
Description: OpenPGP digital signature
