Philip,Thank you for taking out the time to review the package. I have made the suggested changes available on the same link as the RFS. I hope it's fit for sponsorship now. Regards,Sourav
10 Oct 2024, 06:39 by philip.wy...@kathenas.org: > Control: tags -1 +moreinfo > > Souray, > > Preamble... > > Thank you for taking the time to prepare this package and your contribution > to the Debian project. > > The review below is for assistance. This review is offered to help package > submitters to Debian mentors inorder to improve their packages prior to > possible sponsorship into Debian. There is no obligation on behalf of the > submitter to make any alterations based upon information provided in the > review. > > Review... > > 1. Build: > > * pbuilder [1]: Good > * sbuild [2]: Good > > 2. Lintian [3]: Good > > 3. Licenses [4]: Issue > > * Apache-2 needs to be Apache-2.0 > > * 'Files: debian/*' should be under the same license as 'Files: *' section. > > * 'Apache-2.0' license block is as below. > > License: Apache-2.0 > Licensed under the Apache License, Version 2.0 (the "License"); you > may not use this file except in compliance with the License. You may > obtain a copy of the License at > . > http://www.apache.org/licenses/LICENSE-2.0 > . > Unless required by applicable law or agreed to in writing, software > distributed under the License is distributed on an "AS IS" BASIS, > WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. See the License for the specific language governing > permissions and limitations under the License. > . > On Debian systems, the complete text of the Apache version 2.0 > license can be found in "/usr/share/common-licenses/Apache-2.0". > > > 4. Watch file [uscan --force-download]: Good > > 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good > > 6. Reproducible builds [5]: Good > > 7. Install [No previous installs]: Good > > 8. Upgrade [Over previous installs if any]: N/A > > Summary... > > I believe python-nextdns is not yet ready for sponsorship at this time. Could > the contributor rectify one of more of the raised issues. > > Once updated to your satisfaction and a new upload done, please remove the > 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. > > Regards > > Phil > > [1] pbuilder: > > * Command: sudo pbuilder build <PACKAGE>.dsc > * Document: https://wiki.ubuntu.com/PbuilderHowto. > * Document: https://wiki.debian.org/PbuilderTricks > > [2] sbuild: > > * Command: sbuild <PACKAGE>.dsc > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 > * Document: https://wiki.debian.org/sbuild > > [3] lintian: > > * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, > *.changes, *.buildinfo). Each can throw up different results, so be thorough. > * Document: https://wiki.debian.org/Lintian > > [4] lrc: > > * Command: lrc > * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon > > [5] reprotest > > * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- > build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild > * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 > * Document: https://wiki.debian.org/ReproducibleBuilds/ > * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method > > -- > > "I play the game for the game’s own sake" > > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans > > -- > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg > > Internet Relay Chat (IRC): kathenas > > Matrix: #kathenas:matrix.org > > Website: https://kathenas.org > > Instagram: https://instagram.com/kathenasorg/ > > Threads: https://www.threads.net/@kathenasorg > > -- > > > > > >
