On Sat, Sep 14, 2024 at 01:43:53PM +0100, Jeremy Sowden wrote:
> On 2024-09-14, at 06:52:31 -0400, Thomas Dickey wrote:
> > On Sat, Sep 14, 2024 at 02:08:44AM +0100, Phil Wyett wrote:
> > > Control: tags -1 +moreinfo
> > > 
> > > Thomas,
> > > 
> > > Many thanks for addressing some of the issues raised.
> > > 
> > > One lintian issue remains.
> > > 
> > > I: luit source: unused-override no-debian-changes  [debian/source/lintian-
> > > overrides:2]
> > 
> > On removing that file, I get this warning (and by the way do not see the
> > warning which you report):
> > 
> > > run-lintian luit_2.0.20240910-1.dsc luit_2.0.20240910-1_amd64.buildinfo 
> > > luit_2
> > .0.20240910-1_amd64.changes
> > N:
> > W: luit source: no-debian-changes
> > N:
> > N:   This non-native package makes no changes to the upstream sources in the
> > N:   Debian-related files.
> > N:
> > N:   Maybe a mistake was made when the upstream tarball was created, or 
> > maybe
> > N:   this package is really a native package but was built non-native by
> > N:   mistake.
> > N:
> > N:   Debian packaging is sometimes maintained as part of upstream, but that 
> > is
> > N:   not recommended as best practice. Please make this package native, if 
> > the
> > N:   software is only for Debian. Otherwise, please remove the debian 
> > directory
> > N:   from upstream releases and add it in the Debian packaging.
> > N:
> > N:   Format 1.0 packages are subject to the restriction that the diff cannot
> > N:   remove files from the debian directory. For Format 3.0 packages, the
> > N:   debian directory is automatically purged during unpacking.
> > N:
> > N:   Visibility: warning
> > N:   Show-Always: no
> > N:   Check: files/artifact
> > N:   Renamed from: empty-debian-diff
> > N:
> 
> I've just cloned g...@salsa.debian.org:debian/luit, added the missing
> upstream/2.0.20240910 tag, and built the package using gbp-buildpackage.
> I got two lintian warnings:
> 
>   $ schroot -c sid -- lintian --display-info --pedantic --tag-display-limit 0
>   W: luit source: orig-tarball-missing-upstream-signature 
> luit_2.0.20240910.orig.tar.gz
>   I: luit source: unused-override no-debian-changes  
> [debian/source/lintian-overrides:2]
>   N: 0 hints overridden; 1 unused override
> 
> I deleted d/s/lintian-overrides, built the package again and got just
> one:
> 
>   $ schroot -c sid -- lintian --display-info --pedantic --tag-display-limit 0
>   W: luit source: orig-tarball-missing-upstream-signature 
> luit_2.0.20240910.orig.tar.gz
> 
> Do you have local changes that you haven't pushed?

no - I signed the tarball on the 10th, and exported the corresponding labeled
version to github.

However, when I set up this update on salsa (on gitlab, fetching from
github...), it showed my signature as unverified.

After some investigation, I re-added my public key, guessing that salsa was
confused after I updated the expiration date a while back, probably in
January.  Most packagers use the tarballs, but a few of the Debian packages
use github as the media (in a quick check, those are byacc, dialog and luit).

After re-adding my public key, my subsequent commits show as verified.

Perhaps what you're seeing is another symptom of that problem.

-- 
Thomas E. Dickey <dic...@invisible-island.net>
https://invisible-island.net

Attachment: signature.asc
Description: PGP signature

Reply via email to