Julio, Preamble...
Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Isuue bsaf-dev-tools: no-manual-page [usr/bin/convert_image.py] N: N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have N: a manual page N: N: Note that though the man program has the capability to check for several N: program names in the NAMES section, each of these programs should have its N: own manual page (a symbolic link to the appropriate manual page is N: sufficient) because other manual page viewers such as xman or tkman don't N: support this. N: N: If the name of the manual page differs from the binary by case, man may be N: able to find it anyway; however, it is still best practice to match the N: exact capitalization of the executable in the manual page. N: N: If the manual pages are provided by another package on which this package N: depends, Lintian may not be able to determine that manual pages are N: available. In this case, after confirming that all binaries do have manual N: pages after this package and its dependencies are installed, please add a N: Lintian override. N: N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: binary-without-manpage N: N: W: libsaf-dev-tools: script-with-language-extension [usr/bin/convert_image.py] N: N: When scripts are installed into a directory in the system PATH, the script N: name should not include an extension such as .sh or .pl that denotes the N: scripting language currently used to implement it. The implementation N: language may change; if it does, leaving the name the same would be N: confusing and changing it would be disruptive. N: N: Please refer to Scripts (Section 10.4) in the Debian Policy Manual for N: details. N: N: Visibility: warning N: Show-Always: no N: Check: files/scripts This python script is a bit too generic for '/usr/bin/' and primarily useful to your package. I would install it in somewhere like '/use/share/libsaf- dev/tools/' and then there would be no issue with the '.py' file extension. I: libsaf-dev: extra-license-file [usr/share/doc/libsaf-dev/LICENSE.gz] N: N: All license information should be collected in the debian/copyright file. N: This usually makes it unnecessary for the package to install this N: information in other places as well. N: N: Please refer to Copyright information (Section 12.5) in the Debian Policy N: Manual for details. N: N: Visibility: info N: Show-Always: no N: Check: files/licenses This does not need to be packaged. 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: See 2. 8. Upgrade [Over previous installs if any]: N/A <REPLACE_WITH_SUMMARY> Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
