Control: tags -1 +moreinfo Mateusz,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue E: spacefm source: source-is-missing [data/spacefm-manual-en.html] N: N: The source of the following file is missing. Lintian checked a few N: possible paths to find the source, and did not find it. N: N: Please repack your package to include the source or add it to N: "debian/missing-sources" directory. N: N: Please note, that very-long-line-length-in-source-file tagged files are N: likely tagged source-is-missing. It is a feature not a bug. N: N: Visibility: error N: Show-Always: no N: Check: files/source-missing I: spacefm source: duplicate-long-description spacefm-common spacefm-gtk3 [debian/control] N: N: The listed binary packages all share the same extended description. N: N: Please add some additional, useful information to the extended N: descriptions that explain what is in each package and how it differs from N: the next. N: N: It is not okay to rely only on package naming conventions to indicate what N: is inside. N: N: Visibility: info N: Show-Always: no N: Check: debian/control/field/description/duplicate 3. Licenses [4]: Issue, verified philwyett@ks-tarkin:~/Development/builder/debian/mentoring/spacefm-1.0.6$ lrc -t : Versions: recon 1.16 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck GPL-2+ | LGPL-3+ src/ptk/ptk-text-renderer.c GPL-3+ | LGPL src/vfs/vfs-file-monitor.c 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Issue Installed on Debian unstable (default desktop) and up to date. philwyett@ks-dooku:~$ spacefm (spacefm:2826): SpaceFM-WARNING **: 22:33:03.185: No root settings found in /etc/spacefm/ Setting a root editor in Preferences should remove this warning on startup. Otherwise commands run as root may present a security risk. Segmentation fault philwyett@ks-dooku:~$ 8. Upgrade [Over previous installs if any]: Not tested at this time. Summary... I believe spacefm is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
