Control: tags -1 +moreinfo On Thu, 2024-08-29 at 19:59 +0200, Mateusz Łukasik wrote: > Package: sponsorship-requests > Severity: important > > Dear mentors, > > I am looking for a sponsor for my package "spacefm": > > * Package name : spacefm > Version : 1.0.6-8 > Upstream contact : [fill in name and email of upstream] > * URL : https://ignorantguru.github.io/spacefm/ > * License : GPL-3+, LGPL-3+, GAP~Makefile.in, permissive, Zlib, > GPL-2+ > * Vcs : https://github.com/mati75/spacefm.git > Section : utils > > The source builds the following binary packages: > > spacefm - Multi-panel tabbed file manager > spacefm-common - Multi-panel tabbed file manager - common files > (transitional package) > spacefm-gtk3 - Multi-panel tabbed file manager (transitional package) > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/spacefm/ > > Alternatively, you can download the package with 'dget' using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/s/spacefm/spacefm_1.0.6-8.dsc > > Changes since the last upload: > > spacefm (1.0.6-8) unstable; urgency=medium > . > * Add patch from Gentoo to fix FTBFS with gcc-14. (Closes: #1075530) > * Bump to Standards-Version to 4.7.0 > > Regards,
Mateusz, Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Hood 2. Lintian [3]: Issue W: spacefm source: build-depends-on-obsolete-package Build-Depends: pkg- config => pkgconf N: N: The package build-depends on a package that has been superseded. If the N: superseded package is part of an ORed group, it should not be the first N: package in the group. N: N: Visibility: warning N: Show-Always: no N: Check: fields/package-relations I: spacefm source: duplicate-long-description spacefm-common spacefm-gtk3 [debian/control] N: N: The listed binary packages all share the same extended description. N: N: Please add some additional, useful information to the extended N: descriptions that explain what is in each package and how it differs from N: the next. N: N: It is not okay to rely only on package naming conventions to indicate what N: is inside. N: N: Visibility: info N: Show-Always: no N: Check: debian/control/field/description/duplicate I: spacefm source: installable-field-mirrors-source (in section for spacefm- common) Priority [debian/control:41] N: N: The named field for an installation package in debian/control has the same N: value as the one inherited from the source paragraph. N: N: In the interest of shorter and clearer files, you may wish to take N: advantage of the inheritance rules. This field is redundant. N: N: Visibility: info N: Show-Always: no N: Check: debian/control/field/redundant N: Renamed from: binary-control-field-duplicates-source N: N: I: spacefm source: installable-field-mirrors-source (in section for spacefm- gtk3) Priority [debian/control:49] I: spacefm source: patch-not-forwarded-upstream [debian/patches/drop-gnome- common-macros.patch] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: N: I: spacefm source: patch-not-forwarded-upstream [debian/patches/drop_spacefm- installer.patch] N: I: spacefm source: patch-not-forwarded-upstream [debian/patches/fix-gcc10- fno-common.patch] N: I: spacefm source: patch-not-forwarded-upstream [debian/patches/fix-spelling- error.patch] N: I: spacefm source: patch-not-forwarded-upstream [debian/patches/update_desktop_files.patch] P: spacefm source: redundant-globbing-patterns (data/*.png data/faenza/*.png) for data/faenza/spacefm-find.png [debian/copyright:10] N: N: Two globbing patterns in the same Files section in debian/copyright match N: the same file. N: N: This situation can occur when a narrow pattern should apply the same N: license as a broader pattern. Please create another Files section for the N: narrow pattern and place it below other patterns that compete for the same N: files. N: N: Please refer to Bug#905747 and N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for N: details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/copyright/dep5 P: spacefm source: redundant-globbing-patterns (data/*.png data/faenza/*.png) for data/faenza/spacefm-root.png [debian/copyright:10] N: P: spacefm source: redundant-globbing-patterns (data/*.png data/faenza/*.png) for data/faenza/spacefm.png [debian/copyright:10] N: P: spacefm source: renamed-tag debian-watch-does-not-check-gpg-signature => debian-watch-does-not-check-openpgp-signature [debian/source/lintian- overrides:1] N: N: The package has an override for a tag that was renamed. Lintian tag are N: sometime renamed in order to improve their name. N: N: Override file is dynamically translated by Lintian. Nevertheless please N: replace the old name by the new name. N: N: Visibility: pedantic N: Show-Always: yes N: Check: debian/lintian-overrides/mystery P: spacefm source: trailing-whitespace [debian/rules:11] N: N: This file contains lines with trailing whitespace characters. N: N: Whilst often harmless and unsightly, such extra whitespaces can also cause N: tools to interpret the whitespace characters literally. The tool diff(1) N: does not like them, either. They are best avoided. N: N: Some of these problems can be hard to track down. N: N: Whitespace at the end of lines may be removed with the following: N: N: $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog N: N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup). N: N: However, if you wish to only remove trailing spaces and leave trailing N: tabs (eg. for Makefiles), you can use the following code snippet: N: N: $ sed -i -e 's@[ ]*$@@g' debian/rules N: N: To remove empty lines from the end of a file, you can use: N: N: $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/trailing-whitespace N: Renamed from: file-contains-trailing-whitespace 3. Licenses [4]: Issue with possible false positives philwyett@ks-tarkin:~/Development/builder/debian/mentoring/spacefm-1.0.6$ lrc -t : Versions: recon 1.16 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck GPL-3+ | GPL-3 release GPL-2+ | GPL-3+ src/desktop/working-area.c GPL-2+ | LGPL-3+ src/ptk/ptk-text-renderer.c GPL-3+ | LGPL src/vfs/vfs-file-monitor.c 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Not performed at this time 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: Not performed at this time Summary... I believe spacefm is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
