Control: tags -1 +moreinfo On Thu, 2024-08-29 at 19:59 +0200, Mateusz Łukasik wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "smplayer": > > * Package name : smplayer > Version : 24.5.0+ds0-1 > Upstream contact : [fill in name and email of upstream] > * URL : https://smplayer.sourceforge.net/ > * License : [fill in] > * Vcs : https://salsa.debian.org/multimedia-team/smplayer > Section : video > > The source builds the following binary packages: > > smplayer - Complete front-end for MPlayer and mpv > smplayer-l10n - Complete front-end for MPlayer and mpv - translation files > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/smplayer/ > > Alternatively, you can download the package with 'dget' using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/s/smplayer/smplayer_24.5.0+ds0-1.dsc > > Changes since the last upload: > > smplayer (24.5.0+ds0-1) unstable; urgency=medium > . > * New upstream release. > * Update standards version to 4.7.0, no changes needed. > * Update debian/copyright. > * Remove Alf Gaida from Uploaders. > > Regards,
Hi Mateusz, Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue W: smplayer source: syntax-error-in-dep5-copyright Continuation line not in paragraph (line 25). Missing a dot on the previous line? [debian/copyright] N: N: The machine-readable copyright file didn't pass Debian control file syntax N: check. N: N: This issue may hide other issues as Lintian skips some checks on the file N: in this case. N: N: Please refer to N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for N: details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/copyright/dep5 I: smplayer source: older-debian-watch-file-standard 3 [debian/watch] N: N: The version= line in the debian/watch file in this package declares an N: older version. Please upgrade when you have a chance. N: N: Please refer to the uscan(1) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/watch/standard I: smplayer source: patch-not-forwarded-upstream [debian/patches/00_drop_docs_dir.patch] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch I: smplayer source: patch-not-forwarded-upstream [debian/patches/01-update- mime-types.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/04_update_desktop_launcher.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/05-add- debian-hardening-flags.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/07-disable- chromecast.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/08-disable- yt-js.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/09-use- https.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/10_drop_DONATE_REMINDER.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/11-drop- google-dns.patch] N: I: smplayer source: patch-not-forwarded-upstream [debian/patches/12-drop- google-dns-from-chromecast.patch] I: smplayer: spelling-error-in-binary "allows to" "allows one to" [usr/bin/smplayer] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: I: smplayer: spelling-error-in-binary Addd Add [usr/bin/smplayer] N: I: smplayer: spelling-error-in-binary abitrate arbitrate [usr/bin/smplayer] 3. Licenses [4]: Issue, possible false positives philwyett@ks-tarkin:~/Development/builder/debian/mentoring/smplayer- 24.5.0+ds0$ lrc -t : Versions: recon 1.16 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... ** Superfluous file pattern : ** Superfluous file pattern : Running licensecheck .... d/copyright | licensecheck GPL-2+ | GPL with Qt-GPL-Eclipse exception src/findsubtitles/filedownloader/main.cpp LGPL-2.1+ | LGPL-2.1 or LGPL-3 src/myslider.cpp GPL-2+ | GPL-3+ src/youtube/qt-json/json.cpp BSD-3-clause | GPL-2 webserver/mongoose.h 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Not performed at this time 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: Not performed at this time Summary... I believe smplayer is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
