Control: tags -1 -moreinfo Control: tags -1 +confirmed Sebastien,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Non blocking For checking, not blockers. I: serious-sam-tfe: spelling-error-in-binary AddDS Adds [usr/lib/serious- engine/tfe/Bin/libShaders.so] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling N: N: I: serious-sam-tfe: spelling-error-in-binary Ammount Amount [usr/lib/serious- engine/tfe/Bin/libEntities.so] N: I: serious-sam-tfe: spelling-error-in-binary Substract Subtract [usr/lib/serious-engine/tfe/Bin/libEntities.so] N: I: serious-sam-tse: spelling-error-in-binary AddDS Adds [usr/lib/serious- engine/tse/Bin/libShaders.so] N: I: serious-sam-tse: spelling-error-in-binary Ammount Amount [usr/lib/serious- engine/tse/Bin/libEntitiesMP.so] N: I: serious-sam-tse: spelling-error-in-binary Substract Subtract [usr/lib/serious-engine/tse/Bin/libEntitiesMP.so] P: serious-engine source: maintainer-desktop-entry [debian/serious-sam- tfe.desktop] N: N: The maintainer keeps a desktop entry in ./debian. Please forward the N: desktop entry upstream and ask them to include it in their version control N: system, and in their next release. N: N: If the desktop entry was already forwarded or rejected, or the upstream is N: gone, please override the tag and annotate it with a suitable comment. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, and N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual N: for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/desktop-entries X: serious-sam-tfe: executable-in-usr-lib [usr/lib/serious- engine/tfe/Bin/ssam-tfe] N: N: The package ships an executable file in /usr/lib. N: N: Please move the file to /usr/libexec. N: N: With policy revision 4.1.5, Debian adopted the Filesystem Hierarchy N: Specification (FHS) version 3.0. N: N: The FHS 3.0 describes /usr/libexec. Please use that location for N: executables. N: N: Please refer to File System Structure (Section 9.1.1) in the Debian Policy N: Manual, filesystem-hierarchy, N: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html, and N: Bug#954149 for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: files/permissions/usr-lib N: This tag is experimental. N: N: Screen: emacs/elpa/scripts N: Advocates: "David Bremner" <brem...@debian.org> N: Reason: The emacsen-common package places installation and removal N: scripts, which for ELPA packages are executable, in the folder N: /usr/lib/emacsen-common/packages. N: N: About four hundred installation packages are affected. All of N: them declare emacsen-common as an installation prerequisite. N: N: Read more in Bug#974175 and Bug#954149. N: N: Screen: web/cgi/scripts N: Advocates: "Andrius Merkys" <mer...@debian.org> N: Reason: The folder /usr/lib/cgi-bin/ is designated for scripts in the N: Common Gateway Interface (CGI). They require the executable bit N: so the server can run them. N: N: Read more in N: https://en.wikipedia.org/wiki/Common_Gateway_Interface, N: https://datatracker.ietf.org/doc/html/rfc3875.html, and N: Bug#1003941. X: serious-engine source: upstream-metadata-file-is-missing N: N: This source package is not Debian-native but it does not have a N: debian/upstream/metadata file. N: N: The Upstream MEtadata GAthered with YAml (UMEGAYA) project is an effort to N: collect meta-information about upstream projects from any source package. N: This file is in YAML format and it is used in to feed the data in the N: UltimateDebianDatabase. For example, it can contains the way the authors N: want their software be cited in publications and some bibliographic N: references about the software. N: N: Please add a debian/upstream/metadata file. N: N: Please refer to https://dep-team.pages.debian.net/deps/dep12/ and N: https://wiki.debian.org/UpstreamMetadata for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/upstream/metadata N: This tag is experimental. 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Summary... Package is in a good condition Sebastien, kudos. I believe serious-engine is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready and appropriate for the distribution. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
