On Tue, Aug 13, 2024 at 11:07 PM Shengjing Zhu <z...@debian.org> wrote: > > Control: owner -1 ! > > I will sponsor this. But I disagree with the patch[1] you added. > It doesn't look like upstream will accept[2] it as well. > > Based on the comment by upstream[3], I think you can add this script > to maintainer script (postinst). > Many other packages in contrib download external stuff in postinst as well. > With this method, you can ensure users always get the right server > binary if the install process succeeds. > > Another issue is since it no longer builds the server part, the > debian/missing-sources and gradle can be stripped. > > [1] > https://salsa.debian.org/yangfl-guest/scrcpy/-/blob/master/debian/patches/0001-Add-detailed-instruction-to-download-server.patch?ref_type=heads > [2] https://github.com/Genymobile/scrcpy/pull/5172 > [3] https://github.com/Genymobile/scrcpy/pull/5172#issuecomment-2271119422 > > -- > Shengjing Zhu
A script /usr/libexec/scrcpy-update-server is added to handle auto-updating server. I'd use original upstream source tarballs if all possible. If debian/missing-sources is not required along with original source tarball, I'll strip them.
