Control: tags -1 + moreinfo Yangfl,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue I: scrcpy source: missing-explanation-for-contrib-or-non-free-package [debian/copyright:1] N: N: The specified package is in the contrib or non-free archive area but does N: not include a "Comment" (or "Disclaimer") field in its copyright file. N: N: Please add a brief comment why this package cannot be part of the main N: Debian distribution. N: N: Please refer to Copyright information (Section 12.5) in the Debian Policy N: Manual for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/copyright/dep5 I: scrcpy source: quilt-patch-missing-description [debian/patches/download- server-hint.patch] N: N: quilt patch files should start with a description of patch. All lines N: before the start of the patch itself are considered part of the N: description. You can edit the description with quilt header -e when the N: patch is at the top of the stack. N: N: As well as a description of the purpose and function of the patch, the N: description should ideally contain author information, a URL for the bug N: report (if any), Debian or upstream bugs fixed by it, upstream status, the N: Debian version and date the patch was first included, and any other N: information that would be useful if someone were investigating the patch N: and underlying problem. Please consider using the DEP 3 format for this N: information. N: N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/quilt I: scrcpy: spelling-error-in-binary likelyhood likelihood [usr/bin/scrcpy] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling I: scrcpy: typo-in-manual-page likelyhood likelihood [usr/share/man/man1/scrcpy.1.gz:32] N: N: Lintian found a spelling error in a manual page. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext (with the help of po4a, for example) or a similar tool, please fix N: the error in the translations as well as the English text to avoid making N: the translations fuzzy. With gettext, for example, this means you should N: also fix the spelling mistake in the corresponding msgids in the *.po N: files. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: spelling-error-in-manpage N: N: I: scrcpy: typo-in-manual-page occured occurred [usr/share/man/man1/scrcpy.1.gz:382] I: scrcpy: unused-override desktop-command-not-in-package bin/bash [usr/share/applications/scrcpy-console.desktop] [usr/share/lintian/overrides/scrcpy:2] N: N: Your package specifies the named override but there were no tags that N: could have been silenced by it. N: N: Maybe you fixed an underlying condition but forgot to remove the override. N: It is also possible that the Lintian maintainers fixed a false positive. N: N: If the override is now unused, please remove it. N: N: This tag is similar to mismatched-override except there a tag could have N: been silenced if the context had matched. N: N: Sometimes, overrides end up not being used because a tag appears only on N: some architectures. In that case, overrides can be equipped with an N: architecture qualifier. N: N: Please refer to Architecture specific overrides (Section 2.4.3) in the N: Lintian User's Manual for details. N: N: Visibility: info N: Show-Always: yes N: Check: lintian 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... I believe scrcpy is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
