BTW what's the difference with wasi-libc package ? Le dim. 28 juil. 2024 à 12:24, Phil Wyett <philip.wy...@kathenas.org> a écrit :
> On Sun, 2024-07-28 at 15:14 +0900, Daichi Fukui wrote: > > Hi Andrey, Iwamatsu-san, > > CC: Phil, > > > > It's been a while since I posted the draft package some weeks ago. > > I'd appreciate it if you sponsor this and help me upload it. > > > > > Phil > > Besides, I also appreciate Phil for his review work. > > I hope the draft package will be satisfactory and ready to be uploaded. > > > > Best, > > Fukui > > > > On Fri, 28 Jun 2024 at 09:36, Daichi Fukui > > <a.dog.will.t...@akane.waseda.jp> wrote: > > > > > > Control: tags 1058016 - moreinfo > > > > > > Hi Andrey, > > > > > > Thank you for the comments. > > > > > > Though it took some time since your reply, I've updated the draft > > > package following the comments. > > > You can download the latest draft package with 'dget' using this > command: > > > dget -x > https://mentors.debian.net/debian/pool/main/w/wasix-libc/wasix-libc_2024-06-26.1+ds-1.dsc > > > > > > To access further information about this package, please visit the > > > following URL: > > > https://mentors.debian.net/package/wasix-libc/ > > > > > > With regard to the comments, > > > > > > > - It should have only one changelog entry. > > > Now there is only one changelog entry. > > > > > > > - Pre-built libclang_rt.builtins-wasm32.a should be removed from the > > > > orig.tar, assuming it's not used in the build process. > > > The pre-build archive file is now removed from the orig.tar. > > > It is actually used while Makefile is processing > > > tools/append-builtins/wasm32-wasi.mri, but the archive file should be > > > removed according to the Debian Policy. > > > Following that change, the .mri file now refers to the > > > libclang_rt.builtins-wasm32.a archive provided by the > > > libclang-rt-16-dev-wasm32 package. > > > > > > > - debian/rules hardcodes llvm-*-16 and clang-16 but B-D are llvm and > > > > clang, those should use versioned names too. > > > Now B-D uses versioned ones. > > > > > > > - You should follow the comments in debian/rules and debian/watch. > > > Following the comments, unused lines are removed. > > > > > > > - An explicit build target looks unnecessary. > > > The following explicit build process is now removed. > > > --- a/debian/rules > > > +++ b/debian/rules > > > @@ -14,10 +9,6 @@ export TARGET_ARCH = wasm32 > > > %: > > > dh $@ > > > > > > -.PHONY: build > > > -build: > > > - dh $@ > > > - > > > override_dh_auto_build: > > > dh_auto_build -- finish > > > > > > Meanwhile, I found an issue that most of the files from the wasix-libc > > > package are duplicating the files from the wasi-libc package[0]. > > > This is considered an error of our wasix-libc draft package if we do > > > not take measures. > > > One possible solution is to add the Conflicts field to d/control and > > > set wasi-libc to it. > > > I hope this change is satisfactory and useful. > > > > > > [0] https://packages.debian.org/sid/all/wasi-libc/filelist > > > > > > Fukui > > Hi Fukui, > > This package is in the "confirmed" group and awaiting a DD to pick up and > look at and review. I have just sent a begging email to the devel list > asking > for DDs to have a list at this group of packages for hopeful pickup. > > These things can take time though, so please be patient. > > Regards > > Phil > > -- > "I play the game for the game’s own sake" > > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans > > -- > > Internet Relay Chat (IRC): kathenas > > Website: https://kathenas.org > > Instagram: https://instagram.com/kathenasorg/ > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg > > -- > >
