Control: tags 1058016 - moreinfo

Hi Andrey,

Thank you for the comments.

Though it took some time since your reply, I've updated the draft
package following the comments.
You can download the latest draft package with 'dget' using this command:
dget -x 
https://mentors.debian.net/debian/pool/main/w/wasix-libc/wasix-libc_2024-06-26.1+ds-1.dsc

To access further information about this package, please visit the
following URL:
https://mentors.debian.net/package/wasix-libc/

With regard to the comments,

> - It should have only one changelog entry.
Now there is only one changelog entry.

> - Pre-built libclang_rt.builtins-wasm32.a should be removed from the
>  orig.tar, assuming it's not used in the build process.
The pre-build archive file is now removed from the orig.tar.
It is actually used while Makefile is processing
tools/append-builtins/wasm32-wasi.mri, but the archive file should be
removed according to the Debian Policy.
Following that change, the .mri file now refers to the
libclang_rt.builtins-wasm32.a archive provided by the
libclang-rt-16-dev-wasm32 package.

>- debian/rules hardcodes llvm-*-16 and clang-16 but B-D are llvm and
>  clang, those should use versioned names too.
Now B-D uses versioned ones.

>- You should follow the comments in debian/rules and debian/watch.
Following the comments, unused lines are removed.

>- An explicit build target looks unnecessary.
The following explicit build process is now removed.
--- a/debian/rules
+++ b/debian/rules
@@ -14,10 +9,6 @@ export TARGET_ARCH = wasm32
 %:
        dh $@

-.PHONY: build
-build:
-       dh $@
-
 override_dh_auto_build:
        dh_auto_build -- finish

Meanwhile, I found an issue that most of the files from the wasix-libc
package are duplicating the files from the wasi-libc package[0].
This is considered an error of our wasix-libc draft package if we do
not take measures.
One possible solution is to add the Conflicts field to d/control and
set wasi-libc to it.
I hope this change is satisfactory and useful.

[0] https://packages.debian.org/sid/all/wasi-libc/filelist

Fukui

Reply via email to