Control: tags -1 + moreinfo Michael,
Preamble... Thank you for taking the time to create this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build[1]: Good 2. Lintian[2]: Issue W: streamripper source: ancient-libtool 1.3.3 [ltmain.sh] N: N: The referenced file seems to be from a libtool version older than 1.5.2- 2. N: This might lead to build errors on some newer architectures not known to N: this libtool. N: N: Please ask your upstream maintainer to re-libtoolize the package or do it N: yourself if there is no active upstream. You will also need to run N: Autoconf to regenerate the configure script. Usually it is best to do this N: during the build by depending on autoconf, libtool, and automake if it is N: used, and then running: N: N: autoreconf -i --force N: N: before running configure. Depending on how old the package is, this may N: require additional modifications to configure.ac or configure.in or other N: work. If you do this during the build, determine which files it will add N: or update and be sure to remove those files in the clean target. N: N: If you have fixed architecture-specific issues with minimal patches, N: rather than updating libtool, and verified that it builds correctly, N: please override this tag. Lintian will not be able to verify that. N: N: Visibility: warning N: Show-Always: no N: Check: build-systems/autotools/libtool N: N: W: streamripper source: ancient-libtool [ltconfig] N: W: streamripper: groff-message troff:<standard input>:72: warning: macro 'an- trap' not defined [usr/share/man/man1/streamripper.1.gz:1] N: N: A manual page provoked warnings or errors from the man program. Here are N: some common ones: N: N: "cannot adjust" or "can't break" are issues with paragraph filling. They N: are usually related to long lines. Justifying text on the left hand side N: can help with adjustments. Hyphenation can help with breaks. N: N: For more information, please see "Manipulating Filling and Adjusting" and N: "Manipulating Hyphenation" in the Groff manual (see info groff). N: N: "can't find numbered character" usually means that the input was in a N: national legacy encoding. The warning means that some characters were N: dropped. Please use escapes such as \[:a] as described on the groff_char N: manual page. N: N: Other common warnings are formatting typos. String arguments to .IP N: require quotes. Usually, some text is lost or mangled. See the groff_man N: (or groff_mdoc if using mdoc) manual page for details on macros. N: N: The check for manual pages uses the --warnings option to man to catch N: common problems, like a . or a ' at the beginning of a line as literal N: text. They are interpreted as Groff commands. Just reformat the paragraph N: so the characters are not at the beginning of a line. You can also add a N: zero-width space (\&) in front of them. N: N: Aside from overrides, warnings can be disabled with the .warn directive. N: Please see "Debugging" in the Groff manual. N: N: You can see the warnings yourself by running the command used by Lintian: N: N: LC_ALL=C.UTF-8 MANROFFSEQ='' MANWIDTH=80 \ N: man --warnings -E UTF-8 -l -Tutf8 -Z <file> >/dev/null N: N: Please refer to the groff_man(7) manual page and the groff_mdoc(7) manual N: page for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: manpage-has-errors-from-man N: N: W: streamripper source: package-uses-deprecated-debhelper-compat-version 7 N: N: The debhelper compatibility version used by this package is marked as N: deprecated by the debhelper developer. You should really consider using a N: newer compatibility version. N: N: The compatibility version can be set by specifying debhelper-compat (= 12) N: in your package's Build-Depends, by the legacy debian/compat file or even N: by setting and exporting DH_COMPAT in debian/rules. If it is not set in N: either place, debhelper defaults to the deprecated compatibility version N: 1. N: N: Please refer to the debhelper(7) manual page for details. N: N: Visibility: warning N: Show-Always: no N: Check: debhelper N: N: I: streamripper: acute-accent-in-manual-page [usr/share/man/man1/streamripper.1.gz:116] N: N: This manual page uses the \' groff sequence. Usually, the intent is to N: generate an apostrophe, but that sequence actually renders as an acute N: accent. N: N: For an apostrophe or a single closing quote, use plain '. For single N: opening quote, i.e. a straight downward line ' like the one used in shell N: commands, use '\(aq'. N: N: In case this tag was emitted for the second half of a '\\' sequence, this N: is indeed no acute accent, but still wrong: A literal backslash should be N: written \e in the groff format, i.e. a '\\' sequence needs to be changed N: to '\e' which also won't trigger this tag. N: N: Please refer to Bug#554897, Bug#507673, and Bug#966803 for details. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: acute-accent-in-manpage N: N: I: streamripper: hardening-no-bindnow [usr/bin/streamripper] N: N: This package provides an ELF binary that lacks the "bindnow" linker flag. N: N: This is needed (together with "relro") to make the "Global Offset Table" N: (GOT) fully read-only. The bindnow feature trades startup time for N: improved security. Please consider enabling this feature or consider N: overriding the tag (possibly with a comment about why). N: N: If you use dpkg-buildflags, you may have to add hardening=+bindnow or N: hardening=+all to DEB_BUILD_MAINT_OPTIONS. N: N: The relevant compiler flags are set in LDFLAGS. N: N: Please refer to https://wiki.debian.org/Hardening for details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: streamripper: hardening-no-fortify-functions [usr/bin/streamripper] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg- buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: streamripper source: no-dh-sequencer [debian/rules] N: N: This package does not use the dh sequencer in debian/rules. N: N: While maintainers may use a variety of build systems, this one is by far N: the most popular. N: N: Maintainers are strongly encouraged to use the dh sequencer in new N: packages and convert existing ones when appropriate. N: N: Visibility: info N: Show-Always: no N: Check: debian/rules/dh-sequencer N: N: I: streamripper source: out-of-date-standards-version 3.8.1 (released 2009- 03-12) (current is 4.7.0) N: N: The source package refers to a Standards-Version older than the one that N: was current at the time the package was created (according to the N: timestamp of the latest debian/changelog entry). Please consider updating N: the package to current Policy and setting this control field N: appropriately. N: N: If the package is already compliant with the current standards, you don't N: have to re-upload the package just to adjust the Standards-Version control N: field. However, please remember to update this field next time you upload N: the package. N: N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the N: debian-policy package for a summary of changes in newer versions of N: Policy. N: N: Please refer to N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for N: details. N: N: Visibility: info N: Show-Always: no N: Check: fields/standards-version N: N: I: streamripper source: patch-not-forwarded-upstream [debian/patches/1075541- gcc14] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: N: I: streamripper source: patch-not-forwarded-upstream [debian/patches/873964- http] N: I: streamripper source: repackaged-source-not-advertised [debian/copyright] N: N: The debian/copyright file mentions Files-Excluded but the source version N: has no repack suffix. N: N: Repackaged sources are expected to indicate in their version number that N: they are different from the upstream release. It is commonly done by N: adding a repack suffix to the upstream version. N: N: The choice of repack suffix depends on the reason for repackaging. When N: some files were excluded because licensing was a concern, the suffix +dfsg N: may be appropriate. In more generic cases, one could chose +ds. N: N: Upstream sources are sometimes repackaged by accident when using old N: versions of dh_make. It can also happen when a maintainer invokes the N: dh_make option --createorig even though it is not needed. N: N: According to the Debian Developer's Reference 6.7.8.2, the repack suffix N: is not required. N: N: Please include such a suffix in the changelog version number to avoid this N: warning. N: N: Please refer to Bug#471537 and N: https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html N: for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/copyright/dep5 3. Licenses (lrc[3]): Issue philwyett@ks-solo:~/Development/builder/debian/mentoring/streamripper-1.64.6$ lrc -t : Versions: recon 1.13 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck GPL-2 | GPL-2+ console/cstreamripper.c GPL-2 | LGPL-2+ lib/argv.c GPL-2 | GPL-2+ lib/cbuf2.c GPL-2 | GPL-2+ and/or LGPL lib/filelib.h GPL-2 | GPL-2+ lib/findsep.c GPL-2 | LGPL-2+ lib/ripaac.c GPL-2 | GPL-2+ lib/ripogg.c GPL-2 | Expat lib/uce_dirent.h GPL-2 | GPL-2+ lib/utf8.c GPL-2 | GPL streamripper.1 4. Watch file (uscan --force-download): Good 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 6. Reproducible builds (reporotest)[3]: Good 7. Install (No previous installs): Good 8. Upgrade (Over previous installs if any): Good Summary... I believe streamripper is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] Using: * pbuilder - https://wiki.ubuntu.com/PbuilderHowto. * https://wiki.debian.org/PbuilderTricks and * sbuild - https://wiki.debian.org/sbuild. [2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different, so be thorough. [3] 'lrc' from 'licenserecon' is located in Debian testing and newer. [4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part
