Control: tag -1 moreinfo -confirmed
On Thu, Jun 20, 2024 at 07:14:45PM +0200, Bartek Fabiszewski wrote:
> Package: sponsorship-requests
> Severity: important
>
> Dear mentors,
>
> I am looking for a sponsor for my package "libmobi":
>
> * Package name : libmobi
> Version : 0.12+dfsg-1
> Upstream contact : Bartek Fabiszewski <deb...@fabiszewski.net>
> * URL : https://github.com/bfabiszewski/libmobi
> * License : ISC, BSD-4-Clause, Unlicense, public-domain, LGPL-3+
> * Vcs : https://salsa.debian.org/debian/libmobi
> Section : libs
(Review based on the upload 2024-07-21 18:39)
- There are empty files: d/libmobi0.(install,docs,symbols)
--> drop them
- The patches could have dep3 information whether you have applied them
upstream as well.
- There are changes that are not documented in d/changelog, like (not
exhaustive)
- bump of SV to 4.7.0 (did you have to do any changes because of it?) and
- update of d/copyright years (d/copyright should reflect the data in the
source file "verbatim" - you update the copyright years in d/copyright
2024, but did not change the year in your source code. That violates the
"verbatim". So either bump the year in your source code too, or record the
years as they are in
the source
- usually d/changelog's purpose is to document the changes to the Debian
*packaging*, not to document upstream changes. See Policy 4.6. (You've got
your upstream changelog, that is where your upstream changes shoudl got to.
In this case I'd write the changelog as:
libmobi (0.12+dfsg-1) unstable; urgency=medium
* New upstream release. (Closes: #1073331)
* <entry about S-V>
* Updated d/copyright years
* New patches to fixing typo/tweak wording in the manpage
* (...)
-- Bartek Fabiszewski <deb...@fabiszewski.net> Mon, 17 Jun 2024 13:34:25 +0200
--
tobi
